From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5F0FA3728 for ; Fri, 13 Sep 2024 07:59:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D9526B00CB; Fri, 13 Sep 2024 03:59:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 287486B00CC; Fri, 13 Sep 2024 03:59:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1017D6B00CD; Fri, 13 Sep 2024 03:59:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DE74C6B00CB for ; Fri, 13 Sep 2024 03:59:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1C72C1619B5 for ; Fri, 13 Sep 2024 07:59:32 +0000 (UTC) X-FDA: 82558965384.25.6B008B4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 37A47A000D for ; Fri, 13 Sep 2024 07:59:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aTN0b4zl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726214291; a=rsa-sha256; cv=none; b=CuBhOdV5d8W8gfilD40J4a+SkkY1EsmbVmg5nzPQfw/w6bAY7gajlbzaolOFTGkxFu1QgO +krp+J9qNfi0Ytgqt/4knL1RCGaak/y99aSatOMY9+Bsoc+sYsXCaqWMum91Nd0acIj0fI dCpbT7kbLvsg1WibY2FXqQVZkf30Rak= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aTN0b4zl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726214291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AyeF+/WYzR3SYi9omjxf05OynwYJxePvZ/auujDdqu4=; b=RQZTNHq/hequr9nIu/sprX0gzg3ECmtG3utdaRK45iTEu9GXmw9reAbmiX+/9NJIhnLAhx 8Dmyy/NRrhzdLZmrR9KZB3+qV6UUbf/WXtkZun5Dl3sAhHX7U39ztlZtFJR+O6ilYJN8TV yWRJjdsDVGKgnkZhYtDYmNvH/8gX8Zc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726214368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyeF+/WYzR3SYi9omjxf05OynwYJxePvZ/auujDdqu4=; b=aTN0b4zlYVZHiJ1khOXj4B77PH8Zk5JoTocdgq7gkWuxnbyQx+LUA9DHmmExIQq7zJI8M8 CV39u3BWWxdX9pSasG3monZLx/sYBiRC0CpeP1IeuJFjk0I+6zCI0hNRRZ8nxrVwB/fjDD yS6GZitT9Ifrsb91DCdb9zTp78zCJ74= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-OrTa6mQ8NEiM4VnKY-WhyQ-1; Fri, 13 Sep 2024 03:59:25 -0400 X-MC-Unique: OrTa6mQ8NEiM4VnKY-WhyQ-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A94211956077; Fri, 13 Sep 2024 07:59:23 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0215C30001AB; Fri, 13 Sep 2024 07:59:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <202409131438.3f225fbf-oliver.sang@intel.com> References: <202409131438.3f225fbf-oliver.sang@intel.com> To: kernel test robot Cc: dhowells@redhat.com, oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Christian Brauner , Jeff Layton , netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org Subject: Re: [linux-next:master] [netfs] a05b682d49: BUG:KASAN:slab-use-after-free_in_copy_from_iter MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1263137.1726214359.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 13 Sep 2024 08:59:19 +0100 Message-ID: <1263138.1726214359@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Queue-Id: 37A47A000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: uhj6q5zkxo4ndjwsfzgy1ddscy1s4hzy X-HE-Tag: 1726214369-48380 X-HE-Meta: U2FsdGVkX19+pFGG5K9bsElocVyJWJnLhMGUM9uSBdpYnSi5dX2Rxyl8wenM7K8rRT/zNphFKO96j4KL9h9+FovoMG8f7iAD4ul+Xg8s/ICKmZy31zbxMLu3PLqVSWlWRkU2+2KOcYghW0N02tWIlAk+Zvwb/sQR5VyCuDLW64gaok04yMShqreHwLUZpoQFJdugO5Uf9hMFiHWtf+T/gKhSFz7psgAMH9jxIHkmpVR0DgYhUUsjllHguZYsdW3AdDY0tgka+2lzDJHGs+iMCRmRgaHyFfivqWlze+0+Es6iwT9cvqp+pRfbsWx4ZdgJEqhrlOZv3jZQRyDVg87LCNiTwIK79Hs09fB2s1yhcMXoKPN/uBCxJIHT93MY4mgHhSNLUSnVUoNzk3lK1vU1HxWQ6FQl4hGfLpTuqYgBsny6r/8Fj8ATPt1q8Ikvi5cxwmny8Ul2xeAon1EmoP/qKvCjv1V2fYGNHD36YLITe1lL90uXF/MHfxJKpS/JWDoSR9vGwo5qa7oAt70crh8kvDJE/uyEJ8v9plwKxKapEJAVZCl6yjhHYQVqbjlsdiZS3l+zIlm7LjbIvsbpzlNfjrIPRQKO7/0+HypBipPIz845gUOdIZ51ZQx2II1dYZjm3HT6a7FmBOcqFqkPA8IkDLFPne88xEKqC8m240RVh5rDTffwEPHA/1rVJ+0gtmARiLX84jhydUf2yqwc4C0EsBFEbPII0wn6yBBwmqj4PSCMSrkCU7YJzcJrj13NvZYBEcdq0dZ730vEu2ePLwjg9jVbeCrD0BH8TNHwLhV12qxAGRlc+FCA+1HMraDAj7UVm2MZ8M6swyj3/EnorfZlr0buaLlhzpqaZ10qbTP9r8KglHd7O+k6FDukkaTSqxrjPJHWJo1ASYmp/cNvokMBTKON1qjX3bx7CvJFRIClZm4H//ytuvT/Koxvwl5nuGxmNfNnb1vAFNlCDpfPhlL lKhak0ik Bu4wwfUCIXh16i6MIFMVihvZ/CCw3dUf+n9/2VpT4wi1DMqtefxhNXWlDpUjqpMfDIg8uE4eKUsePE3fgMP6IOCJ1I1XwL2TsWLPhpeuVZR0N+6p/EnJ1Wv7+yJFtt7Dri6uMaPPQI657liL7/ZOs6M9uAB96vNXZoAC0RcZ6GaLR6mXl1UC88hkAYL8JE+GLhOsn0mP4GXHB02IlxjnJWIJ7WSpwdAa4qInopn+1X8YwgX2b6AcTDmaqferO14zbdrL0P1Sh8XSL4+TWpkx3JJzpvE8ITMZaWBBPjPKUjgy/qe/UP65UnbWJ6j3eB28UaJrLxqIahKwgUpAf3yDy5k/vlPh1lLMKnZHd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Can you try with the attached change? It'll get folded into Christian's vfs.netfs branch at some point. David --- diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 84a517a0189d..97003155bfac 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -1026,7 +1026,7 @@ static ssize_t iter_folioq_get_pages(struct iov_iter= *iter, iov_offset +=3D part; extracted +=3D part; = - *pages =3D folio_page(folio, offset % PAGE_SIZE); + *pages =3D folio_page(folio, offset / PAGE_SIZE); get_page(*pages); pages++; maxpages--;