From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: linux-mm <linux-mm@kvack.org>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>
Subject: [PATCH] mm: remove unevictable_migrate_page function
Date: Wed, 02 Dec 2009 13:35:41 -0500 [thread overview]
Message-ID: <1259778941.4088.176.camel@useless.americas.hpqcorp.net> (raw)
unevictable_migrate_page() in mm/internal.h is a relic of the
since removed UNEVICTABLE_LRU Kconfig option. This patch removes
the function and open codes the test in migrate_page_copy().
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/internal.h | 12 ------------
mm/migrate.c | 4 ++--
2 files changed, 2 insertions(+), 14 deletions(-)
Index: linux-2.6.32-rc8/mm/internal.h
===================================================================
--- linux-2.6.32-rc8.orig/mm/internal.h 2009-11-24 13:19:58.000000000 -0500
+++ linux-2.6.32-rc8/mm/internal.h 2009-12-01 13:33:11.000000000 -0500
@@ -74,18 +74,6 @@ static inline void munlock_vma_pages_all
}
#endif
-/*
- * unevictable_migrate_page() called only from migrate_page_copy() to
- * migrate unevictable flag to new page.
- * Note that the old page has been isolated from the LRU lists at this
- * point so we don't need to worry about LRU statistics.
- */
-static inline void unevictable_migrate_page(struct page *new, struct page *old)
-{
- if (TestClearPageUnevictable(old))
- SetPageUnevictable(new);
-}
-
#ifdef CONFIG_HAVE_MLOCKED_PAGE_BIT
/*
* Called only in fault path via page_evictable() for a new page
Index: linux-2.6.32-rc8/mm/migrate.c
===================================================================
--- linux-2.6.32-rc8.orig/mm/migrate.c 2009-11-24 13:19:58.000000000 -0500
+++ linux-2.6.32-rc8/mm/migrate.c 2009-12-01 13:32:48.000000000 -0500
@@ -341,8 +341,8 @@ static void migrate_page_copy(struct pag
if (TestClearPageActive(page)) {
VM_BUG_ON(PageUnevictable(page));
SetPageActive(newpage);
- } else
- unevictable_migrate_page(newpage, page);
+ } else if (TestClearPageUnevictable(page))
+ SetPageUnevictable(newpage);
if (PageChecked(page))
SetPageChecked(newpage);
if (PageMappedToDisk(page))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-12-02 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 18:35 Lee Schermerhorn [this message]
2009-12-02 19:44 ` Christoph Lameter
2009-12-05 13:09 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259778941.4088.176.camel@useless.americas.hpqcorp.net \
--to=lee.schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox