linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remove the redundant code
@ 2009-11-30  3:00 Huang Shijie
  0 siblings, 0 replies; only message in thread
From: Huang Shijie @ 2009-11-30  3:00 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, Huang Shijie

The check code for CONFIG_SWAP is redundant, because there is
a non-CONFIG_SWAP version for PageSwapCache() which just returns 0.

So the check code here is confusing when people see the code
in page-flags.h.

Signed-off-by: Huang Shijie <shijie8@gmail.com>
---
 include/linux/mm.h |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 24c3956..a85ed43 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -634,12 +634,9 @@ static inline struct address_space *page_mapping(struct page *page)
 	struct address_space *mapping = page->mapping;
 
 	VM_BUG_ON(PageSlab(page));
-#ifdef CONFIG_SWAP
 	if (unlikely(PageSwapCache(page)))
 		mapping = &swapper_space;
-	else
-#endif
-	if (unlikely((unsigned long)mapping & PAGE_MAPPING_ANON))
+	else if (unlikely((unsigned long)mapping & PAGE_MAPPING_ANON))
 		mapping = NULL;
 	return mapping;
 }
-- 
1.6.0.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-11-30  3:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-30  3:00 [PATCH] remove the redundant code Huang Shijie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox