From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 29B316B009A for ; Tue, 24 Nov 2009 16:35:58 -0500 (EST) Subject: Re: lockdep complaints in slab allocator From: Peter Zijlstra In-Reply-To: References: <84144f020911192249l6c7fa495t1a05294c8f5b6ac8@mail.gmail.com> <1258709153.11284.429.camel@laptop> <84144f020911200238w3d3ecb38k92ca595beee31de5@mail.gmail.com> <1258714328.11284.522.camel@laptop> <4B067816.6070304@cs.helsinki.fi> <1258729748.4104.223.camel@laptop> <1259002800.5630.1.camel@penberg-laptop> <1259003425.17871.328.camel@calx> <4B0ADEF5.9040001@cs.helsinki.fi> <1259080406.4531.1645.camel@laptop> <20091124170032.GC6831@linux.vnet.ibm.com> <1259082756.17871.607.camel@calx> <1259086459.4531.1752.camel@laptop> <1259090615.17871.696.camel@calx> <1259095580.4531.1788.camel@laptop> <1259096004.17871.716.camel@calx> <1259096519.4531.1809.camel@laptop> <1259097150.4531.1822.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Tue, 24 Nov 2009 22:35:52 +0100 Message-ID: <1259098552.4531.1857.camel@laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: Matt Mackall , paulmck@linux.vnet.ibm.com, Pekka Enberg , linux-mm@kvack.org, Christoph Lameter , LKML , Nick Piggin List-ID: On Tue, 2009-11-24 at 13:22 -0800, David Rientjes wrote: > On Tue, 24 Nov 2009, Peter Zijlstra wrote: > > > > slqb still has a 5-10% performance regression compared to slab for > > > benchmarks such as netperf TCP_RR on machines with high cpu counts, > > > forcing that type of regression isn't acceptable. > > > > Having _4_ slab allocators is equally unacceptable. > > > > So you just advocated to merging slqb so that it gets more testing and > development, and then use its inclusion in a statistic to say we should > remove others solely because the space is too cluttered? We should cull something, just merging more and more of them is useless and wastes everybody's time since you have to add features and interfaces to all of them. > We use slab partially because the regression in slub was too severe for > some of our benchmarks, and while CONFIG_SLUB may be the kernel default > there are still distros that use slab as the default as well. We cannot > simply remove an allocator that is superior to others because it is old or > has increased complexity. Then maybe we should toss SLUB? But then there's people who say SLUB is better for them. Without forcing something to happen we'll be stuck with multiple allocators forever. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org