From: Jiri Slaby <jirislaby@gmail.com>
To: npiggin@suse.de
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>, Tejun Heo <tj@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Christoph Lameter <cl@linux-foundation.org>
Subject: [PATCH 1/1] MM: slqb, fix per_cpu access
Date: Sun, 1 Nov 2009 23:12:58 +0100 [thread overview]
Message-ID: <1257113578-1584-1-git-send-email-jirislaby@gmail.com> (raw)
We cannot use the same local variable name as the declared per_cpu
variable since commit "percpu: remove per_cpu__ prefix."
Otherwise we would see crashes like:
general protection fault: 0000 [#1] SMP
last sysfs file:
CPU 1
Modules linked in:
Pid: 1, comm: swapper Tainted: G W 2.6.32-rc5-mm1_64 #860
RIP: 0010:[<ffffffff8142ff94>] [<ffffffff8142ff94>] start_cpu_timer+0x2b/0x87
...
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Tejun Heo <tj@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christoph Lameter <cl@linux-foundation.org>
---
mm/slqb.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/slqb.c b/mm/slqb.c
index e745d9a..27f5025 100644
--- a/mm/slqb.c
+++ b/mm/slqb.c
@@ -2770,16 +2770,16 @@ static DEFINE_PER_CPU(struct delayed_work, cache_trim_work);
static void __cpuinit start_cpu_timer(int cpu)
{
- struct delayed_work *cache_trim_work = &per_cpu(cache_trim_work, cpu);
+ struct delayed_work *_cache_trim_work = &per_cpu(cache_trim_work, cpu);
/*
* When this gets called from do_initcalls via cpucache_init(),
* init_workqueues() has already run, so keventd will be setup
* at that time.
*/
- if (keventd_up() && cache_trim_work->work.func == NULL) {
- INIT_DELAYED_WORK(cache_trim_work, cache_trim_worker);
- schedule_delayed_work_on(cpu, cache_trim_work,
+ if (keventd_up() && _cache_trim_work->work.func == NULL) {
+ INIT_DELAYED_WORK(_cache_trim_work, cache_trim_worker);
+ schedule_delayed_work_on(cpu, _cache_trim_work,
__round_jiffies_relative(HZ, cpu));
}
}
--
1.6.4.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-11-01 22:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 22:12 Jiri Slaby [this message]
2009-11-02 4:22 ` Tejun Heo
2009-11-02 8:49 ` Jiri Slaby
2009-11-02 11:48 ` Dave Young
2009-11-02 15:24 ` Tejun Heo
2009-11-02 16:24 ` Christoph Lameter
2009-11-02 13:23 ` Rusty Russell
2009-11-02 15:31 ` Jiri Slaby
2009-11-04 7:45 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257113578-1584-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox