From: Gleb Natapov <gleb@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/11] Send async PF when guest is not in userspace too.
Date: Sun, 1 Nov 2009 13:56:30 +0200 [thread overview]
Message-ID: <1257076590-29559-12-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1257076590-29559-1-git-send-email-gleb@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
arch/x86/kvm/mmu.c | 16 ++++++----------
1 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 3d33994..21ec65a 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2358,7 +2358,7 @@ static bool kvm_asyc_pf_is_done(struct kvm_vcpu *vcpu)
spin_lock(&vcpu->arch.mmu_async_pf_lock);
list_for_each_entry_safe(p, node, &vcpu->arch.mmu_async_pf_done, link) {
- if (p->guest_task != vcpu->arch.pv_shm->current_task)
+ if (p->token != vcpu->arch.pv_shm->param)
continue;
list_del(&p->link);
found = true;
@@ -2370,7 +2370,7 @@ static bool kvm_asyc_pf_is_done(struct kvm_vcpu *vcpu)
p->error_code);
put_page(p->page);
async_pf_work_free(p);
- trace_kvm_mmu_async_pf_wait(vcpu->arch.pv_shm->current_task, 0);
+ trace_kvm_mmu_async_pf_wait(vcpu->arch.pv_shm->param, 0);
}
return found;
}
@@ -2378,7 +2378,7 @@ static bool kvm_asyc_pf_is_done(struct kvm_vcpu *vcpu)
int kvm_pv_wait_for_async_pf(struct kvm_vcpu *vcpu)
{
++vcpu->stat.pf_async_wait;
- trace_kvm_mmu_async_pf_wait(vcpu->arch.pv_shm->current_task, 1);
+ trace_kvm_mmu_async_pf_wait(vcpu->arch.pv_shm->param, 1);
wait_event(vcpu->wq, kvm_asyc_pf_is_done(vcpu));
return 0;
@@ -2386,17 +2386,13 @@ int kvm_pv_wait_for_async_pf(struct kvm_vcpu *vcpu)
static bool can_do_async_pf(struct kvm_vcpu *vcpu)
{
- struct kvm_segment kvm_seg;
-
if (!vcpu->arch.pv_shm ||
!(vcpu->arch.pv_shm->features & KVM_PV_SHM_FEATURES_ASYNC_PF) ||
- kvm_event_needs_reinjection(vcpu))
+ kvm_event_needs_reinjection(vcpu) ||
+ !kvm_x86_ops->interrupt_allowed(vcpu))
return false;
- kvm_get_segment(vcpu, &kvm_seg, VCPU_SREG_CS);
-
- /* is userspace code? TODO check VM86 mode */
- return !!(kvm_seg.selector & 3);
+ return true;
}
static int setup_async_pf(struct kvm_vcpu *vcpu, gpa_t cr3, gva_t gva,
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-11-01 11:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 11:56 [PATCH 00/11] KVM: Add asynchronous page fault for PV guest Gleb Natapov
2009-11-01 11:56 ` [PATCH 01/11] Add shared memory hypercall to PV Linux guest Gleb Natapov
2009-11-02 4:27 ` Rik van Riel
2009-11-02 7:07 ` Gleb Natapov
2009-11-02 12:18 ` Avi Kivity
2009-11-02 16:18 ` Gleb Natapov
2009-11-03 5:15 ` Avi Kivity
2009-11-03 7:16 ` Gleb Natapov
2009-11-03 7:40 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 02/11] Add "handle page fault" PV helper Gleb Natapov
2009-11-02 9:22 ` Ingo Molnar
2009-11-02 16:04 ` Gleb Natapov
2009-11-02 16:12 ` Ingo Molnar
2009-11-02 16:22 ` Gleb Natapov
2009-11-02 16:29 ` Ingo Molnar
2009-11-02 16:31 ` Gleb Natapov
2009-11-02 17:42 ` Gleb Natapov
2009-11-08 11:36 ` Ingo Molnar
2009-11-08 12:43 ` Avi Kivity
2009-11-08 12:51 ` Ingo Molnar
2009-11-08 13:01 ` Avi Kivity
2009-11-08 13:05 ` Ingo Molnar
2009-11-08 13:08 ` Avi Kivity
2009-11-08 16:44 ` H. Peter Anvin
2009-11-08 16:47 ` Ingo Molnar
2009-11-02 19:03 ` Rik van Riel
2009-11-02 19:33 ` Avi Kivity
2009-11-02 23:35 ` Rik van Riel
2009-11-03 4:57 ` Avi Kivity
2009-11-05 6:44 ` Tian, Kevin
2009-11-05 8:22 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 03/11] Handle asynchronous page fault in a PV guest Gleb Natapov
2009-11-02 12:38 ` Avi Kivity
2009-11-02 15:54 ` Gleb Natapov
2009-11-03 14:14 ` Marcelo Tosatti
2009-11-03 14:25 ` Gleb Natapov
2009-11-03 14:32 ` Marcelo Tosatti
2009-11-03 14:38 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 04/11] Export __get_user_pages_fast Gleb Natapov
2009-11-02 9:23 ` Ingo Molnar
2009-11-01 11:56 ` [PATCH 05/11] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2009-11-02 19:05 ` Rik van Riel
2009-11-01 11:56 ` [PATCH 06/11] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov
2009-11-02 12:56 ` Avi Kivity
2009-11-02 15:41 ` Gleb Natapov
2009-11-01 11:56 ` [PATCH 07/11] Retry fault before vmentry Gleb Natapov
2009-11-02 13:03 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 08/11] Add "wait for page" hypercall Gleb Natapov
2009-11-02 13:05 ` Avi Kivity
2009-11-02 15:13 ` Gleb Natapov
2009-11-02 15:19 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 09/11] Maintain preemptability count even for !CONFIG_PREEMPT kernels Gleb Natapov
2009-11-02 9:24 ` Ingo Molnar
2009-11-01 11:56 ` [PATCH 10/11] Handle async PF in non preemptable context Gleb Natapov
2009-11-01 11:56 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257076590-29559-12-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox