From: Gleb Natapov <gleb@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 10/11] Handle async PF in non preemptable context.
Date: Sun, 1 Nov 2009 13:56:29 +0200 [thread overview]
Message-ID: <1257076590-29559-11-git-send-email-gleb@redhat.com> (raw)
In-Reply-To: <1257076590-29559-1-git-send-email-gleb@redhat.com>
If async page fault is received by idle task or when preemp_count is
not zero guest cannot reschedule, so make "wait for page" hypercall
and comtinue only after a page is ready.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
arch/x86/kernel/kvm.c | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 79d291f..1bd8b8d 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -162,10 +162,24 @@ int kvm_handle_pf(struct pt_regs *regs, unsigned long error_code)
switch (reason) {
default:
return 0;
- case KVM_PV_REASON_PAGE_NP:
+ case KVM_PV_REASON_PAGE_NP: {
+ int cpu, idle;
+ cpu = get_cpu();
+ idle = idle_cpu(cpu);
+ put_cpu();
+
+ /*
+ * We cannot reschedule. Wait for page to be ready.
+ */
+ if (idle || preempt_count()) {
+ kvm_hypercall0(KVM_HC_WAIT_FOR_ASYNC_PF);
+ break;
+ }
+
/* real page is missing. */
apf_task_wait(current, token);
break;
+ }
case KVM_PV_REASON_PAGE_READY:
apf_task_wake(token);
break;
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-01 11:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 11:56 [PATCH 00/11] KVM: Add asynchronous page fault for PV guest Gleb Natapov
2009-11-01 11:56 ` [PATCH 01/11] Add shared memory hypercall to PV Linux guest Gleb Natapov
2009-11-02 4:27 ` Rik van Riel
2009-11-02 7:07 ` Gleb Natapov
2009-11-02 12:18 ` Avi Kivity
2009-11-02 16:18 ` Gleb Natapov
2009-11-03 5:15 ` Avi Kivity
2009-11-03 7:16 ` Gleb Natapov
2009-11-03 7:40 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 02/11] Add "handle page fault" PV helper Gleb Natapov
2009-11-02 9:22 ` Ingo Molnar
2009-11-02 16:04 ` Gleb Natapov
2009-11-02 16:12 ` Ingo Molnar
2009-11-02 16:22 ` Gleb Natapov
2009-11-02 16:29 ` Ingo Molnar
2009-11-02 16:31 ` Gleb Natapov
2009-11-02 17:42 ` Gleb Natapov
2009-11-08 11:36 ` Ingo Molnar
2009-11-08 12:43 ` Avi Kivity
2009-11-08 12:51 ` Ingo Molnar
2009-11-08 13:01 ` Avi Kivity
2009-11-08 13:05 ` Ingo Molnar
2009-11-08 13:08 ` Avi Kivity
2009-11-08 16:44 ` H. Peter Anvin
2009-11-08 16:47 ` Ingo Molnar
2009-11-02 19:03 ` Rik van Riel
2009-11-02 19:33 ` Avi Kivity
2009-11-02 23:35 ` Rik van Riel
2009-11-03 4:57 ` Avi Kivity
2009-11-05 6:44 ` Tian, Kevin
2009-11-05 8:22 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 03/11] Handle asynchronous page fault in a PV guest Gleb Natapov
2009-11-02 12:38 ` Avi Kivity
2009-11-02 15:54 ` Gleb Natapov
2009-11-03 14:14 ` Marcelo Tosatti
2009-11-03 14:25 ` Gleb Natapov
2009-11-03 14:32 ` Marcelo Tosatti
2009-11-03 14:38 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 04/11] Export __get_user_pages_fast Gleb Natapov
2009-11-02 9:23 ` Ingo Molnar
2009-11-01 11:56 ` [PATCH 05/11] Add get_user_pages() variant that fails if major fault is required Gleb Natapov
2009-11-02 19:05 ` Rik van Riel
2009-11-01 11:56 ` [PATCH 06/11] Inject asynchronous page fault into a guest if page is swapped out Gleb Natapov
2009-11-02 12:56 ` Avi Kivity
2009-11-02 15:41 ` Gleb Natapov
2009-11-01 11:56 ` [PATCH 07/11] Retry fault before vmentry Gleb Natapov
2009-11-02 13:03 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 08/11] Add "wait for page" hypercall Gleb Natapov
2009-11-02 13:05 ` Avi Kivity
2009-11-02 15:13 ` Gleb Natapov
2009-11-02 15:19 ` Avi Kivity
2009-11-01 11:56 ` [PATCH 09/11] Maintain preemptability count even for !CONFIG_PREEMPT kernels Gleb Natapov
2009-11-02 9:24 ` Ingo Molnar
2009-11-01 11:56 ` Gleb Natapov [this message]
2009-11-01 11:56 ` [PATCH 11/11] Send async PF when guest is not in userspace too Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257076590-29559-11-git-send-email-gleb@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox