From: Mel Gorman <mel@csn.ul.ie>
To: Frans Pop <elendil@planet.nl>, Jiri Kosina <jkosina@suse.cz>,
Sven Geggus <lists@fuchsschwanzdomain.de>,
Karol Lewandowski <karol.k.lewandowski@gmail.com>,
Tobias Oetiker <tobi@oetiker.ch>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
David Miller <davem@davemloft.net>,
Reinette Chatre <reinette.chatre@intel.com>,
Kalle Valo <kalle.valo@iki.fi>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mohamed Abbas <mohamed.abbas@intel.com>,
Jens Axboe <jens.axboe@oracle.com>,
"John W. Linville" <linville@tuxdriver.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Stephan von Krawczynski <skraw@ithnet.com>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"linux-mm@kvack.org\"" <linux-mm@kvack.org>,
Mel Gorman <mel@csn.ul.ie>
Subject: [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER
Date: Thu, 22 Oct 2009 15:22:33 +0100 [thread overview]
Message-ID: <1256221356-26049-3-git-send-email-mel@csn.ul.ie> (raw)
In-Reply-To: <1256221356-26049-1-git-send-email-mel@csn.ul.ie>
Commit 341ce06f69abfafa31b9468410a13dbd60e2b237 altered watermark logic
slightly by allowing rt_tasks that are handling an interrupt to set
ALLOC_HARDER. This patch brings the watermark logic more in line with
2.6.30.
[rientjes@google.com: Spotted the problem]
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
mm/page_alloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index dfa4362..7f2aa3e 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1769,7 +1769,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
* See also cpuset_zone_allowed() comment in kernel/cpuset.c.
*/
alloc_flags &= ~ALLOC_CPUSET;
- } else if (unlikely(rt_task(p)))
+ } else if (unlikely(rt_task(p)) && !in_interrupt())
alloc_flags |= ALLOC_HARDER;
if (likely(!(gfp_mask & __GFP_NOMEMALLOC))) {
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-22 14:22 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 14:22 [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Mel Gorman
2009-10-22 14:22 ` [PATCH 1/5] page allocator: Always wake kswapd when restarting an allocation attempt after direct reclaim failed Mel Gorman
2009-10-22 14:24 ` [PATCH 1/5 Against 2.6.31.4] " Mel Gorman
2009-10-22 14:41 ` [PATCH 1/5] " Pekka Enberg
2009-10-22 15:49 ` Mel Gorman
2009-10-26 1:11 ` KOSAKI Motohiro
2009-10-26 7:10 ` David Rientjes
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-27 12:27 ` Mel Gorman
2009-10-22 14:22 ` Mel Gorman [this message]
2009-10-22 16:33 ` [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER Stephan von Krawczynski
2009-10-22 16:37 ` Mel Gorman
2009-10-23 9:57 ` Stephan von Krawczynski
2009-10-24 2:03 ` Christoph Lameter
2009-10-27 15:19 ` Mel Gorman
2009-10-25 12:57 ` Stephan von Krawczynski
2009-10-26 1:15 ` KOSAKI Motohiro
2009-10-22 14:22 ` [PATCH 3/5] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit Mel Gorman
2009-10-23 17:52 ` Vincent Li
2009-10-23 22:12 ` Vincent Li
2009-10-27 10:38 ` Mel Gorman
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-22 14:22 ` [PATCH 4/5] page allocator: Pre-emptively wake kswapd when high-order watermarks are hit Mel Gorman
2009-10-22 19:41 ` David Rientjes
2009-10-23 9:13 ` Mel Gorman
2009-10-23 9:36 ` David Rientjes
2009-10-23 11:25 ` Mel Gorman
2009-10-23 11:31 ` Tobias Oetiker
2009-10-23 13:39 ` Mel Gorman
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-27 15:26 ` Mel Gorman
2009-10-22 14:22 ` [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING Revert 373c0a7e, 8aa7e847: Fix congestion_wait() sync/async vs read/write confusion Mel Gorman
2009-10-22 14:25 ` Against 2.6.31.4 [PATCH 5/5] " Mel Gorman
2009-10-22 21:49 ` [PATCH 5/5] ONLY-APPLY-IF-STILL-FAILING " Jens Axboe
2009-10-27 2:42 ` KOSAKI Motohiro
2009-10-27 10:29 ` Frans Pop
2009-10-22 14:47 ` [PATCH 0/5] Candidate fix for increased number of GFP_ATOMIC failures V2 Pekka Enberg
2009-10-22 16:03 ` Mel Gorman
2009-10-24 1:52 ` Christoph Lameter
2009-10-24 6:48 ` Pekka Enberg
2009-10-24 6:48 ` Pekka Enberg
2009-10-22 15:43 ` reinette chatre
2009-10-27 10:40 ` Mel Gorman
2009-10-27 23:34 ` reinette chatre
2009-10-23 7:31 ` Sven Geggus
2009-10-23 16:58 ` Karol Lewandowski
2009-10-23 21:12 ` Karol Lewandowski
2009-10-24 13:46 ` Mel LKML
2009-10-28 11:42 ` Karol Lewandowski
2009-10-28 11:59 ` Mel Gorman
2009-10-30 14:23 ` Karol Lewandowski
2009-11-02 20:30 ` Mel Gorman
2009-11-04 2:03 ` Karol Lewandowski
2009-10-28 12:55 ` Tobi Oetiker
2009-10-24 13:51 ` Frans Pop
2009-10-24 14:02 ` Sven Geggus
2009-10-27 13:27 ` Mel Gorman
2009-10-26 17:37 ` Tobias Oetiker
2009-10-27 15:36 ` Mel Gorman
2009-10-26 22:17 ` Frans Pop
2009-10-26 23:45 ` Frans Pop
2009-11-06 6:03 ` Tobias Diedrich
2009-11-06 9:24 ` Mel Gorman
2009-11-06 9:24 ` Mel Gorman
2009-11-06 11:15 ` Tobias Diedrich
2009-11-12 19:30 [PATCH 0/5] Reduce GFP_ATOMIC allocation failures, candidate fix V3 Mel Gorman
2009-11-12 19:30 ` [PATCH 2/5] page allocator: Do not allow interrupts to use ALLOC_HARDER Mel Gorman
2009-11-13 5:24 ` KOSAKI Motohiro
2009-11-13 13:56 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256221356-26049-3-git-send-email-mel@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=jkosina@suse.cz \
--cc=kalle.valo@iki.fi \
--cc=karol.k.lewandowski@gmail.com \
--cc=kernel-testers@vger.kernel.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linville@tuxdriver.com \
--cc=lists@fuchsschwanzdomain.de \
--cc=mohamed.abbas@intel.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=reinette.chatre@intel.com \
--cc=rientjes@google.com \
--cc=rjw@sisk.pl \
--cc=skraw@ithnet.com \
--cc=tobi@oetiker.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox