From: Eric Paris <eparis@redhat.com>
To: Danny Feng <dfeng@redhat.com>
Cc: cl@linux-foundation.org, penberg@cs.helsinki.fi, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [GIT BISECT] BUG kmalloc-8192: Object already free from kmem_cache_destroy
Date: Sun, 13 Sep 2009 23:25:39 -0400 [thread overview]
Message-ID: <1252898739.5793.4.camel@dhcp231-106.rdu.redhat.com> (raw)
In-Reply-To: <4AADB5EE.9090902@redhat.com>
On Mon, 2009-09-14 at 11:18 +0800, Danny Feng wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index b627675..40e12d5 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3337,8 +3337,8 @@ struct kmem_cache *kmem_cache_create(const char
> *name, size_t size,
> goto err;
> }
> return s;
> - }
> - kfree(s);
> + } else
> + kfree(s);
> }
> up_write(&slub_lock);
>
Doesn't the return inside the conditional take care of this? I'll give
it a try in the morning, but I don't see how this can solve the
problem....
-Eric
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-14 3:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 18:33 Eric Paris
2009-09-13 23:11 ` Eric Paris
2009-09-14 1:52 ` Danny Feng
2009-09-14 3:13 ` Eric Paris
2009-09-14 3:41 ` Danny Feng
2009-09-14 6:27 ` Pekka Enberg
2009-09-14 3:18 ` Danny Feng
2009-09-14 3:25 ` Eric Paris [this message]
2009-09-14 3:29 ` Danny Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252898739.5793.4.camel@dhcp231-106.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=cl@linux-foundation.org \
--cc=dfeng@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox