Re: [PATCH 5/6] hugetlb: add per node hstate attributes

[Lee Schermerhorn <Lee.Schermerhorn@hp.com>]

On Thu, 2009-09-10 at 12:50 -0700, David Rientjes wrote:
> On Thu, 10 Sep 2009, Lee Schermerhorn wrote:
> 
> > PATCH 5/7 - hugetlb:  promote NUMA_NO_NODE to generic constant
> > 
> > Against:  2.6.31-rc7-mmotm-090827-1651
> > 
> > Move definition of NUMA_NO_NODE from ia64 and x86_64 arch specific
> > headers to generic header 'linux/numa.h' for use in generic code.
> > NUMA_NO_NODE replaces bare '-1' where it's used in this series to
> > indicate "no node id specified".  Ultimately, it can be used
> > to replace the -1 elsewhere where it is used similarly.
> > 
> > Note that in arch/x86/include/asm/topology.h, NUMA_NO_NODE is
> > now only defined when CONFIG_NUMA is defined.  This seems to work
> > for current usage of NUMA_NO_NODE in x86_64 arch code, with or
> > without CONFIG_NUMA defined.
> > 
> > Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> Thought I recommended this in 
> http://marc.info/?l=linux-mm&m=125201173730752

Yeah, but that was before the long weekend... 

> 
> You could now convert NID_INVAL to NUMA_NO_NODE and remove the duplicate 
> constant as I earlier suggested to cleanup the acpi code.

Could now be done, as you say...

Meanwhile, I'm working on a bit more "clean up".




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>