From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: catalin.marinas@arm.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
penberg@cs.helsinki.fi, mcgrof@gmail.com,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH v3 5/5] kmemleak: fix sparse warning for static declarations
Date: Fri, 4 Sep 2009 17:44:54 -0700 [thread overview]
Message-ID: <1252111494-7593-6-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1252111494-7593-1-git-send-email-lrodriguez@atheros.com>
This fixes these sparse warnings:
mm/kmemleak.c:1179:6: warning: symbol 'start_scan_thread' was not declared. Should it be static?
mm/kmemleak.c:1194:6: warning: symbol 'stop_scan_thread' was not declared. Should it be static?
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
mm/kmemleak.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index d078621..9b14e24 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -1269,7 +1269,7 @@ static int kmemleak_scan_thread(void *arg)
* Start the automatic memory scanning thread. This function must be called
* with the scan_mutex held.
*/
-void start_scan_thread(void)
+static void start_scan_thread(void)
{
if (scan_thread)
return;
@@ -1284,7 +1284,7 @@ void start_scan_thread(void)
* Stop the automatic memory scanning thread. This function must be called
* with the scan_mutex held.
*/
-void stop_scan_thread(void)
+static void stop_scan_thread(void)
{
if (scan_thread) {
kthread_stop(scan_thread);
--
1.6.3.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-05 0:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 0:44 [PATCH v3 0/5] kmemleak: few small cleanups and clear command support Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 1/5] kmemleak: use bool for true/false questions Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-08 16:11 ` Catalin Marinas
2009-09-08 16:16 ` Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 4/5] kmemleak: fix sparse warning over overshadowed flags Luis R. Rodriguez
2009-09-05 8:49 ` Pekka Enberg
2009-09-05 0:44 ` Luis R. Rodriguez [this message]
2009-09-07 17:29 ` [PATCH v3 0/5] kmemleak: few small cleanups and clear command support Catalin Marinas
2009-09-08 16:14 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252111494-7593-6-git-send-email-lrodriguez@atheros.com \
--to=lrodriguez@atheros.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@gmail.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox