From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79BFC352A1 for ; Tue, 6 Dec 2022 18:35:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 325948E0003; Tue, 6 Dec 2022 13:35:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D5938E0001; Tue, 6 Dec 2022 13:35:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19EF68E0003; Tue, 6 Dec 2022 13:35:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C6CF8E0001 for ; Tue, 6 Dec 2022 13:35:48 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD391A0400 for ; Tue, 6 Dec 2022 18:35:47 +0000 (UTC) X-FDA: 80212735134.09.313E9CE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 8D78B40019 for ; Tue, 6 Dec 2022 18:35:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ux3g3GqI; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670351746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BPCIfnbDBpjs4efIHZ8WUm5LDTwrZwzaxy+bAhXeEOE=; b=Wii1Gkawe/s27Wbdgf48tFwIhpUHmDn62Rp4Ap09jbvrgzk2q3jN5oOwzI6dWdG7JAoAxW p0pPjtOOX2xOZkpcYOoa/do1nBqMTDnkYaMNOtO0nKKI/X7TX3SEnpfmREMFhaa+tOjRZM uz5ckoM/OrFMZQYG7k6iCs79JHnNzTk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ux3g3GqI; spf=pass (imf27.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670351746; a=rsa-sha256; cv=none; b=u1fNU6VcCB4emUfpuSWfxTafptbq0CJt9fV8T0+oFRdTwGG0oo8IXhPA8OTp+kJqPTav2W CeRt8CI/TseesbPmrotLI9wNPj22muxQWqTmPO53srPkm3bKf2bC9HsGc95tLWsgpu2N4W OdbmWd+TuioofN+klBjnC0ryyjiezbo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670351746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BPCIfnbDBpjs4efIHZ8WUm5LDTwrZwzaxy+bAhXeEOE=; b=Ux3g3GqIOT8S5bEFeBddpm4ghnYIBNJ9BZw0zFO4ZKUjN4ieY1H20qwlqc+MnoAxj1uwBw STCmSB/RKgqKtcaUzYVyJsuqOraQsmoHb9Er5hgXNGpOupr6hazI8GJvgQC8TGsaVbTTXp ziXcs8W1zSA18M984eJzwLWT/79j4SU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-RMqL0D19PX-y6CNUMWUZug-1; Tue, 06 Dec 2022 13:35:42 -0500 X-MC-Unique: RMqL0D19PX-y6CNUMWUZug-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0EB94811E75; Tue, 6 Dec 2022 18:35:42 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D27A492B04; Tue, 6 Dec 2022 18:35:40 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <0d62615c-57d1-922b-5ebc-32faabf33327@deltatee.com> References: <0d62615c-57d1-922b-5ebc-32faabf33327@deltatee.com> <166997419665.9475.15014699817597102032.stgit@warthog.procyon.org.uk> <166997421646.9475.14837976344157464997.stgit@warthog.procyon.org.uk> To: Logan Gunthorpe Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Jeff Layton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] iov_iter: Add a function to extract a page list from an iterator MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1251302.1670351737.1@warthog.procyon.org.uk> Date: Tue, 06 Dec 2022 18:35:37 +0000 Message-ID: <1251303.1670351737@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spamd-Result: default: False [-1.94 / 9.00]; BAYES_HAM(-2.04)[87.36%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[redhat.com,none]; R_SPF_ALLOW(-0.20)[+ip4:170.10.129.0/24]; R_DKIM_ALLOW(-0.20)[redhat.com:s=mimecast20190719]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_TRACE(0.00)[redhat.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[] X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8D78B40019 X-Stat-Signature: 3tsc9m65yi7jnrzgoxsks83h1m8c3y67 X-HE-Tag: 1670351746-174696 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Logan Gunthorpe wrote: > If this is going to be a general replacement for iov_iter_get_pages() > it's going to need to pass through gup_flags. My recent patchset added > versions with these and I think it should be in during the next merge > cycle. [1] Cool. Note that the current iov_iter_get_pages2() is broken, which is why Al wanted a replacement. It should not be taking a ref on the pages in an XARRAY, BVEC or PIPE - and it should be pinning rather than getting a ref on pages in IOVEC or UBUF if the buffer is being read into. I'm guessing that your changes move the latter decision to the caller? David