From: Fernando Carrijo <fcarrijo@yahoo.com.br>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vincent Li <macli@brc.ubc.ca>, linux-mm@kvack.org
Subject: Re: [PATCH] mm/vmscan: rename zone_nr_pages() to zone_lru_nr_pages()
Date: Fri, 21 Aug 2009 14:36:35 -0300 [thread overview]
Message-ID: <1250876195.4830.24.camel@pc-fernando> (raw)
In-Reply-To: <1250875922.4830.21.camel@pc-fernando>
On Fri, 2009-08-21 at 14:32 -0300, Fernando Carrijo wrote:
> I sent this very message yesterday and somehow it got lost. Today I'm
> resending it with the hope breaks through whatever spam filter it may
> find in its way...
Oops!
I just received the answers to the suggestions I made yesterday.
Sorry for the noise!
>
> On Thu, 2009-08-20 at 17:22 -0700, Andrew Morton wrote:
> > On Thu, 20 Aug 2009 17:19:28 -0700 (PDT)
> > Vincent Li <macli@brc.ubc.ca> wrote:
> >
> > > On Thu, 20 Aug 2009, Andrew Morton wrote:
> > >
> > > > On Thu, 20 Aug 2009 11:42:54 -0700
> > > > Vincent Li <macli@brc.ubc.ca> wrote:
> > > >
> > > > > Name zone_nr_pages can be mis-read as zone's (total) number pages, but it actually returns
> > > > > zone's LRU list number pages.
> > > >
> > > > Fair enough.
> > > >
> > > > > -static unsigned long zone_nr_pages(struct zone *zone, struct scan_control *sc,
> > > > > +static unsigned long zone_lru_nr_pages(struct zone *zone, struct scan_control *sc,
> > > >
> > > > Wouldn't zone_nr_lru_pages() be better?
> > >
> > > I see name isolate_lru_page and the meaning of number of lru pages. your suggestion is better.
> > > should I resend the patch with your suggestion? I ask because I saw you already put the patch in
> > > the mmotm tree before you send this email out.
> > >
> >
> > I edited the diff ;)
>
> Wouldn't it make sense to try to keep some consistency by renaming the
> function mem_cgroup_zone_nr_pages to mem_cgroup_zone_nr_lru_pages, for
> it also deals with a specific LRU?
>
> Fernando Carrijo
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-08-21 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 18:42 Vincent Li
2009-08-20 23:00 ` Andrew Morton
2009-08-21 0:19 ` Vincent Li
2009-08-21 0:22 ` Andrew Morton
2009-08-21 17:32 ` Fernando Carrijo
2009-08-21 17:36 ` Fernando Carrijo [this message]
2009-08-21 1:23 ` Fernando Carrijo
2009-08-21 17:29 ` Vincent Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250876195.4830.24.camel@pc-fernando \
--to=fcarrijo@yahoo.com.br \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=macli@brc.ubc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox