From: Vincent Li <macli@brc.ubc.ca>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>, Vincent Li <macli@brc.ubc.ca>
Subject: [PATCH] mm/vmscan: rename zone_nr_pages() to zone_lru_nr_pages()
Date: Thu, 20 Aug 2009 11:42:54 -0700 [thread overview]
Message-ID: <1250793774-7969-1-git-send-email-macli@brc.ubc.ca> (raw)
Name zone_nr_pages can be mis-read as zone's (total) number pages, but it actually returns
zone's LRU list number pages.
I know reading the code would clear the name confusion, want to know if patch making sense.
Signed-off-by: Vincent Li <macli@brc.ubc.ca>
---
mm/vmscan.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 00596b9..9a55cb3 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -148,7 +148,7 @@ static struct zone_reclaim_stat *get_reclaim_stat(struct zone *zone,
return &zone->reclaim_stat;
}
-static unsigned long zone_nr_pages(struct zone *zone, struct scan_control *sc,
+static unsigned long zone_lru_nr_pages(struct zone *zone, struct scan_control *sc,
enum lru_list lru)
{
if (!scanning_global_lru(sc))
@@ -1479,10 +1479,10 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc,
unsigned long ap, fp;
struct zone_reclaim_stat *reclaim_stat = get_reclaim_stat(zone, sc);
- anon = zone_nr_pages(zone, sc, LRU_ACTIVE_ANON) +
- zone_nr_pages(zone, sc, LRU_INACTIVE_ANON);
- file = zone_nr_pages(zone, sc, LRU_ACTIVE_FILE) +
- zone_nr_pages(zone, sc, LRU_INACTIVE_FILE);
+ anon = zone_lru_nr_pages(zone, sc, LRU_ACTIVE_ANON) +
+ zone_lru_nr_pages(zone, sc, LRU_INACTIVE_ANON);
+ file = zone_lru_nr_pages(zone, sc, LRU_ACTIVE_FILE) +
+ zone_lru_nr_pages(zone, sc, LRU_INACTIVE_FILE);
if (scanning_global_lru(sc)) {
free = zone_page_state(zone, NR_FREE_PAGES);
@@ -1590,7 +1590,7 @@ static void shrink_zone(int priority, struct zone *zone,
int file = is_file_lru(l);
unsigned long scan;
- scan = zone_nr_pages(zone, sc, l);
+ scan = zone_lru_nr_pages(zone, sc, l);
if (priority || noswap) {
scan >>= priority;
scan = (scan * percent[file]) / 100;
--
1.6.0.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-08-20 18:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 18:42 Vincent Li [this message]
2009-08-20 23:00 ` Andrew Morton
2009-08-21 0:19 ` Vincent Li
2009-08-21 0:22 ` Andrew Morton
2009-08-21 17:32 ` Fernando Carrijo
2009-08-21 17:36 ` Fernando Carrijo
2009-08-21 1:23 ` Fernando Carrijo
2009-08-21 17:29 ` Vincent Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250793774-7969-1-git-send-email-macli@brc.ubc.ca \
--to=macli@brc.ubc.ca \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox