* [RFC PATCH] slub: release kobject if sysfs_create_group failed in sysfs_slab_add
@ 2009-07-17 11:08 Xiaotian Feng
2009-07-17 16:39 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Xiaotian Feng @ 2009-07-17 11:08 UTC (permalink / raw)
To: cl, penberg, mpm, linux-mm; +Cc: linux-kernel, Xiaotian Feng
In sysfs_slab_add, after kobject_init_and_add, kobject is inited and added.
Later, if sysfs_create_group fails, just simply return an error. This may
cause a memory leak. unlink and put the kobject if sysfs_create_group failed.
Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
---
mm/slub.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index b9f1491..f910964 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4543,8 +4543,11 @@ static int sysfs_slab_add(struct kmem_cache *s)
}
err = sysfs_create_group(&s->kobj, &slab_attr_group);
- if (err)
+ if (err) {
+ kobject_del(&s->kobj);
+ kobject_put(&s->kobj);
return err;
+ }
kobject_uevent(&s->kobj, KOBJ_ADD);
if (!unmergeable) {
/* Setup first alias */
--
1.6.2.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] slub: release kobject if sysfs_create_group failed in sysfs_slab_add
2009-07-17 11:08 [RFC PATCH] slub: release kobject if sysfs_create_group failed in sysfs_slab_add Xiaotian Feng
@ 2009-07-17 16:39 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2009-07-17 16:39 UTC (permalink / raw)
To: Xiaotian Feng; +Cc: penberg, mpm, linux-mm, linux-kernel
Acked-by: Christoph Lameter <cl@linux-foundation.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-17 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-17 11:08 [RFC PATCH] slub: release kobject if sysfs_create_group failed in sysfs_slab_add Xiaotian Feng
2009-07-17 16:39 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox