From: Catalin Marinas <catalin.marinas@arm.com>
To: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: kmemleak hexdump proposal
Date: Tue, 14 Jul 2009 15:17:42 +0100 [thread overview]
Message-ID: <1247581062.28240.97.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20090714140349.GA3145@localdomain.by>
On Tue, 2009-07-14 at 17:03 +0300, Sergey Senozhatsky wrote:
> On (07/14/09 14:39), Catalin Marinas wrote:
> > On Tue, 2009-07-14 at 13:57 +0300, Sergey Senozhatsky wrote:
> > [...]
> > > +/*
> > > + * Printing of the objects hex dump to the seq file. The number on lines
> > > + * to be printed is limited to HEX_MAX_LINES to prevent seq file spamming.
> > > + * The actual number of printed bytes depends on HEX_ROW_SIZE.
> > > + * It must be called with the object->lock held.
> > > + */
> > [...]
> >
> > The patch looks fine. Could you please add a description and
> > Signed-off-by line?
> >
>
> Sure. During 30-40 minutes (sorry, I'm a bit busy now). OK?
There is no hurry, sometime in the next few weeks :-)
> Should I update Documentation/kmemeleak.txt either?
I don't think this is needed as it doesn't say much about the format of
the debug/kmemleak file (and that's pretty clear, no need to explain
what a hex dump means).
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-14 13:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 17:36 Sergey Senozhatsky
2009-06-29 9:43 ` Pekka Enberg
2009-06-29 9:48 ` Catalin Marinas
2009-06-29 10:19 ` Sergey Senozhatsky
2009-06-29 10:19 ` Pekka Enberg
2009-06-29 10:38 ` Catalin Marinas
2009-06-29 10:42 ` Pekka Enberg
2009-06-29 10:52 ` Sergey Senozhatsky
2009-06-29 20:10 ` Sergey Senozhatsky
2009-07-14 10:07 ` Catalin Marinas
2009-07-14 10:33 ` Sergey Senozhatsky
2009-07-14 10:34 ` Catalin Marinas
2009-07-14 10:57 ` Sergey Senozhatsky
2009-07-14 13:39 ` Catalin Marinas
2009-07-14 14:03 ` Sergey Senozhatsky
2009-07-14 14:17 ` Catalin Marinas [this message]
2009-07-14 15:22 ` kmemleak: Printing of the objects hex dump Sergey Senozhatsky
2009-06-29 10:45 ` kmemleak hexdump proposal Sergey Senozhatsky
2009-06-29 10:58 ` Catalin Marinas
2009-06-29 11:08 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247581062.28240.97.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@cs.helsinki.fi \
--cc=sergey.senozhatsky@mail.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox