From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id A82376B004F for ; Tue, 14 Jul 2009 09:08:24 -0400 (EDT) Subject: Re: kmemleak hexdump proposal From: Catalin Marinas In-Reply-To: <20090714105709.GB2929@localdomain.by> References: <20090629201014.GA5414@localdomain.by> <1247566033.28240.46.camel@pc1117.cambridge.arm.com> <20090714103356.GA2929@localdomain.by> <1247567641.28240.51.camel@pc1117.cambridge.arm.com> <20090714105709.GB2929@localdomain.by> Content-Type: text/plain Date: Tue, 14 Jul 2009 14:39:41 +0100 Message-Id: <1247578781.28240.92.camel@pc1117.cambridge.arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Sergey Senozhatsky Cc: Pekka Enberg , "Paul E. McKenney" , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 2009-07-14 at 13:57 +0300, Sergey Senozhatsky wrote: [...] > +/* > + * Printing of the objects hex dump to the seq file. The number on lines > + * to be printed is limited to HEX_MAX_LINES to prevent seq file spamming. > + * The actual number of printed bytes depends on HEX_ROW_SIZE. > + * It must be called with the object->lock held. > + */ [...] The patch looks fine. Could you please add a description and Signed-off-by line? Thanks. -- Catalin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org