linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: kmemleak not tainted
Date: Tue, 07 Jul 2009 13:47:39 +0100	[thread overview]
Message-ID: <1246970859.9451.34.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20090707115128.GA3238@localdomain.by>

On Tue, 2009-07-07 at 14:51 +0300, Sergey Senozhatsky wrote:
> kernel: [ 1917.133154] INFO: RCU detected CPU 0 stall (t=485140/3000 jiffies)

That's the relevant message. With CONFIG_RCU_CPU_STALL_DETECTOR you may
get these messages.

> static struct kmemleak_object *find_and_get_object(unsigned long ptr, int alias)
> {
> 	unsigned long flags;
> 	struct kmemleak_object *object = NULL;
> 
> 	rcu_read_lock();
> 	read_lock_irqsave(&kmemleak_lock, flags);
> 	if (ptr >= min_addr && ptr < max_addr)
> 		object = lookup_object(ptr, alias);
> >>	read_unlock_irqrestore(&kmemleak_lock, flags);
> 
> 	/* check whether the object is still available */
> 	if (object && !get_object(object))
> 		object = NULL;
> 	rcu_read_unlock();
> 
> 	return object;
> }

It just happened here because that's where the interrupts were enabled
and the timer routine invoked. The rcu-locked region above should be
pretty short (just a tree look-up).

What I think happens is that the kmemleak thread runs for several
seconds for scanning the memory and there may not be any context
switches. I have a patch to add more cond_resched() calls throughout the
kmemleak_scan() function which I hope will get merged. I don't get any
of these messages with CONFIG_PREEMPT enabled.

-- 
Catalin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-07-07 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 11:51 Sergey Senozhatsky
2009-07-07 12:47 ` Catalin Marinas [this message]
2009-07-07 13:17   ` Sergey Senozhatsky
2009-07-07 13:22     ` Catalin Marinas
2009-07-07 13:45       ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246970859.9451.34.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=sergey.senozhatsky@mail.by \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox