From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28503C282EC for ; Tue, 11 Mar 2025 20:15:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46309280002; Tue, 11 Mar 2025 16:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41366280001; Tue, 11 Mar 2025 16:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B41D280002; Tue, 11 Mar 2025 16:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0D705280001 for ; Tue, 11 Mar 2025 16:15:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DA53A1A0626 for ; Tue, 11 Mar 2025 20:15:21 +0000 (UTC) X-FDA: 83210374842.02.7120284 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 320B680015 for ; Tue, 11 Mar 2025 20:15:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DSY1Yh1J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AOPuZBRa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fRspo3fo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kXcGZ1Vm; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741724119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MOymMAqxQuWdddRLmuh9+YU6OLKrxhKGbPPHnJzrflY=; b=p6ObnfltkcHMdrvjh7zDuA+Bcc/xkiXcc0eC+/toZyjHVdOQfsrhpV7MJ9Zb3MjMVBU+Eo pf424z/JALVZeCDXkvbC/Bc/vxQv6RhMnirwWiUnpT8/j2marnpgcjMSMPthpCFKrUGy/W wYylVHdlWcn/R8VaPJ1cW6fuJgkvjfI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741724119; a=rsa-sha256; cv=none; b=sgTApCY50OL1d4RkYPP8/7KyBkJfOjW/VA6xtQGm3dahl8mYJUBKeNhoA7OFa/+RGATgCI uh1wZF3HLhIRBC56jBSoxU2DoZJyq5dTXypza26SA7y6X58GvkzHvVL6as0V8sgXg1/UsH eNoA0xVnaXVicQzmloh5h7b6//3OwEo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DSY1Yh1J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=AOPuZBRa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fRspo3fo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kXcGZ1Vm; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C9ECA2117D; Tue, 11 Mar 2025 20:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741724117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOymMAqxQuWdddRLmuh9+YU6OLKrxhKGbPPHnJzrflY=; b=DSY1Yh1JOVv/ZTzcEVsr9Ti1k9cmcp22Scvv2CWSTQX3axcqqi3rW3t0x2Pynyi+DwqyHR ZuY/Ulf1yNNiR/f3Rnar/X0aKAwe57XY0sZxT7VgPyfBvR3o1/QRE1L7MjS/fJAn5/7EMO iEbHrQ8WoA0Oi5a2Mcp/zEqgbDGv0ac= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741724117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOymMAqxQuWdddRLmuh9+YU6OLKrxhKGbPPHnJzrflY=; b=AOPuZBRaUBqYhLrakEgihcY4LJWL5b9svAc2c/X6W9ZvXBM4plw5Nv2jJ55KzMXiBbzDfn skKgz0yMOhT8V1Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741724116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOymMAqxQuWdddRLmuh9+YU6OLKrxhKGbPPHnJzrflY=; b=fRspo3fok3Djsq0C0D/DB5ui1oCrOZP5AUscfN+gf9QlFPoyMIG746eUTe7zAU8Nml+ckp YHZbtCLD0IBe1z1pL3bgLqbgyDLTCUbxa5Aa5TykH+CVAU32xueaNbZbRfJDUROxQ0KrV1 E74CMv5qVFtXTnocqS+iRb8qX+LWcsI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741724116; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOymMAqxQuWdddRLmuh9+YU6OLKrxhKGbPPHnJzrflY=; b=kXcGZ1Vmr4aoGYZRETCaSzu18GsByerx0YeDPI4/+vBPNPNwndvKfARFu3MlKrERsFOHbu wm5/JAzb8hI398Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0C56134A0; Tue, 11 Mar 2025 20:15:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5DmmJtSZ0GeiQQAAD6G6ig (envelope-from ); Tue, 11 Mar 2025 20:15:16 +0000 Message-ID: <12460463-a2c4-4d02-b3fd-42a490d500a9@suse.cz> Date: Tue, 11 Mar 2025 21:15:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: Fix memory accept before watermarks gets initialized To: "Kirill A. Shutemov" , Andrew Morton Cc: Mike Rapoport , David Hildenbrand , Mel Gorman , Tom Lendacky , "Kalra, Ashish" , Rick Edgecombe , linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Farrah Chen References: <20250310082855.2587122-1-kirill.shutemov@linux.intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20250310082855.2587122-1-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 320B680015 X-Stat-Signature: iqa9c6w386hqtyksc7sd5fwxexaxfah8 X-Rspamd-Server: rspam10 X-HE-Tag: 1741724118-893451 X-HE-Meta: U2FsdGVkX1/hKIxAuUnG+GLzp065Ty/zybCbpSCMstds8DNT2etRMBrRSkGWRRzccaRYUYejE/9ZbSQiBatOLLTeL4SDIAogu0CWz2WIOjUpMTBe98IlcE1Y13C7BNAqfnAyYoQoiUm9DfJNcd91oJ34BqMhyK64bQslW7ZXF0eAG15Rd2CM2CyNjMrVBKzJXuIWp6Z3cKR2lRKJ5Ndin4wBK0nFRtb72o1aDhKSGUhrg/qnb+As4GR+7fknQUqUCC68iDBXyCJa20sVppw6URl5Tlw8RCLBD0iRvpFwZ6zs4P8hjllNVAxqbDin8+XBD/ybtnAe8p5K95d9ZIjGl+Vx+YVoshGZSJOja5l4YAFQ+Jh3WYakeUWha9wHbwWvANQQ1Fan7s8ojGwOGexgpdEXrDsj8RQcCOyNhSK84B7rOtLqYSyZQJu4G14BMGm104+owppO15JVlSOOK3BVOsvZs0frAANHpEKylZ/8q5CIwmyFhHJoBGdZLOZ49ZFsZMZAzix69hkJr6fndquyExj5jS8ifPhycFzR7VrJW3vBKOKaMy6AR9Hlsqu2ttZVgEOCUy8HTRK8msLca7f4x4Q1BqMyPQKuJQDWu33M0heHOFTIrMKTwiIscdtiJAqG7HOAH+LHX4wdstBBr8Sy3yZ9LX9arCsDrPnUgPMuj+Xu8EFUllawq6IgQ4gM+uIrqEkAvXt9M2mj4pyZgGF3qAG9DnyEXV4y3Ynjl/wPIm+5uavGlA0r8bDepmxx9DQk489n3kxlp9wt1kl+Fejpl8td3WI7XjU/caejQPOpC07FrD16FobmlPRqyEvjld7/kRLcW0wxde3eEVjwZJBir5uhAoaPESeTwkyb2GfBPeEgzan3dzMenebXbw9HRZWlYWRCYLpithd45Jva4bjogHAXNNoZZVA63omWFU/iM0dMAYD2JA9AgdlY1wPr1s6BxEGapnuAwPy7H1ckqRH XdCYq2y+ mo+LI2fZvlgDsRJKhDLgjZ9tUreXff1ZdkzJAiV1Me39WETC3PAUrWqa01L2JlArR+HgCy5CDtPsr9Zll3wnBZZRSzPrrKmzq5zj2evmVGzvr7B2KupdaqsBObCpb0znSJzbyT72CUGIaVdQwOwzyG6z7ltg9wbiYxqOWgeho5xpmGBIp74rVB0n6XB3mZGfkpxaPsnPv4TpolQA8LYjaFbWm7b5QmzAaAi08cKrVZZJZ13QTib1X6gludIzoqZgadQx8RcdUwaFDbrDsjdzc9k6rN4YbTT9jkopscFhG1zZy9kunMmmYUYHe8zIGE/uh16NLS5aySI/AyTSneUXf/bubOVxk7/ftIMsgTDU9uh8WlYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/10/25 09:28, Kirill A. Shutemov wrote: > Watermarks are initialized during the postcore initcall. Until then, all > watermarks are set to zero. This causes cond_accept_memory() to > incorrectly skip memory acceptance because a watermark of 0 is always > met. > > To ensure progress, accept one MAX_ORDER page if the watermark is zero. > > Signed-off-by: Kirill A. Shutemov > Reported-and-tested-by: Farrah Chen Acked-by: Vlastimil Babka > --- > mm/page_alloc.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 579789600a3c..4fe93029bcb6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7004,7 +7004,7 @@ static inline bool has_unaccepted_memory(void) > > static bool cond_accept_memory(struct zone *zone, unsigned int order) > { > - long to_accept; > + long to_accept, wmark; > bool ret = false; > > if (!has_unaccepted_memory()) > @@ -7013,8 +7013,18 @@ static bool cond_accept_memory(struct zone *zone, unsigned int order) > if (list_empty(&zone->unaccepted_pages)) > return false; > > + wmark = promo_wmark_pages(zone); > + > + /* > + * Watermarks have not been initialized yet. > + * > + * Accepting one MAX_ORDER page to ensure progress. > + */ > + if (!wmark) > + return try_to_accept_memory_one(zone); > + > /* How much to accept to get to promo watermark? */ > - to_accept = promo_wmark_pages(zone) - > + to_accept = wmark - > (zone_page_state(zone, NR_FREE_PAGES) - > __zone_watermark_unusable_free(zone, order, 0) - > zone_page_state(zone, NR_UNACCEPTED));