From: Pekka Enberg <penberg@cs.helsinki.fi>
To: paulmck@linux.vnet.ibm.com
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cl@linux-foundation.org, jdb@comx.dk,
Nick Piggin <npiggin@suse.de>
Subject: Re: [PATCH RFC] fix RCU-callback-after-kmem_cache_destroy problem in sl[aou]b
Date: Fri, 26 Jun 2009 11:45:13 +0300 [thread overview]
Message-ID: <1246005913.27533.21.camel@penberg-laptop> (raw)
In-Reply-To: <20090625220837.GD8852@linux.vnet.ibm.com>
On Thu, 2009-06-25 at 15:08 -0700, Paul E. McKenney wrote:
> On Thu, Jun 25, 2009 at 04:27:19PM -0500, Matt Mackall wrote:
> > On Thu, 2009-06-25 at 12:31 -0700, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > Jesper noted that kmem_cache_destroy() invokes synchronize_rcu() rather
> > > than rcu_barrier() in the SLAB_DESTROY_BY_RCU case, which could result
> > > in RCU callbacks accessing a kmem_cache after it had been destroyed.
> > >
> > > The following untested (might not even compile) patch proposes a fix.
> >
> > Acked-by: Matt Mackall <mpm@selenic.com>
> >
> > Nick, you'll want to make sure you get this in SLQB.
> >
> > > Reported-by: Jesper Dangaard Brouer <jdb@comx.dk>
>
> And I seem to have blown Jesper's email address (apologies, Jesper!), so:
>
> Reported-by: Jesper Dangaard Brouer <hawk@comx.dk>
Compiles and boots here so I went ahead and applied the patch. ;) Thanks
a lot Paul!
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-26 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 19:31 Paul E. McKenney
2009-06-25 21:27 ` Matt Mackall
2009-06-25 22:08 ` Paul E. McKenney
2009-06-26 8:45 ` Pekka Enberg [this message]
2009-06-26 9:03 ` Nick Piggin
2009-06-26 9:11 ` Pekka Enberg
2009-06-29 22:30 ` Christoph Lameter
2009-06-29 22:45 ` Matt Mackall
2009-06-29 23:19 ` Christoph Lameter
2009-06-30 0:06 ` Matt Mackall
2009-06-30 6:00 ` Paul E. McKenney
2009-06-30 6:58 ` Pekka Enberg
2009-06-30 14:20 ` Christoph Lameter
2009-06-30 14:26 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246005913.27533.21.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=jdb@comx.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=npiggin@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox