linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sergey Senozhatsky <sergey.senozhatsky@mail.by>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: kmemleak suggestion (long message)
Date: Fri, 26 Jun 2009 09:25:40 +0100	[thread overview]
Message-ID: <1246004740.30717.3.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20090626065923.GA14078@elte.hu>

On Fri, 2009-06-26 at 08:59 +0200, Ingo Molnar wrote:
> * Sergey Senozhatsky <sergey.senozhatsky@mail.by> wrote:
> > Currently kmemleak prints info about all objects. I guess 
> > sometimes kmemleak gives you more than you actually need.
> 
> It prints _a lot_ of info and spams the syslog. I lost crash info a 
> few days ago due to that: by the time i inspected a crashed machine 
> the tons of kmemleak output scrolled out the crash from the dmesg 
> buffer.
> 
> This is not acceptable.
> 
> Instead it should perhaps print _at most_ a single line every few 
> minutes, printing a summary about _how many_ leaked entries it 
> suspects, and should offer a /debug/mm/kmemleak style of file where 
> the entries can be read out from.

I agree as well. It already provides the /sys/kernel/debug/kmemleak
which triggers a scan and shows possible leaks. That's easily fixable.

BTW, this was questioned in the past as well - do we still need the
automatic scanning from a kernel thread? Can a user cron job just read
the kmemleak file?

-- 
Catalin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-06-26  8:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25 22:18 Sergey Senozhatsky
2009-06-26  6:59 ` Ingo Molnar
2009-06-26  7:07   ` Pekka Enberg
2009-06-26  8:14     ` Sergey Senozhatsky
2009-06-26  8:17       ` Pekka Enberg
2009-06-26  8:50         ` Sergey Senozhatsky
2009-06-26  8:54           ` Catalin Marinas
2009-06-26  9:13             ` Sergey Senozhatsky
2009-06-26  9:20             ` Alan Cox
2009-06-26 16:12           ` Catalin Marinas
2009-06-26 22:48             ` Sergey Senozhatsky
2009-06-26  7:48   ` Sergey Senozhatsky
2009-06-26  8:25   ` Catalin Marinas [this message]
2009-06-26  8:27     ` Pekka Enberg
2009-06-26  8:41       ` Catalin Marinas
2009-06-26  8:42       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1246004740.30717.3.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=sergey.senozhatsky@mail.by \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox