* mm: Move pgtable_cache_init() earlier
@ 2009-06-17 3:48 Benjamin Herrenschmidt
2009-06-17 4:16 ` Pekka Enberg
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2009-06-17 3:48 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-mm, David S. Miller, Chris Zankel, linuxppc-dev list
Some architectures need to initialize SLAB caches to be able
to allocate page tables. They do that from pgtable_cache_init()
so the later should be called earlier now, best is before
vmalloc_init().
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Note: Only powerpc, sparc and xtensa use this and only to
call kmem_cache_create() so with a bit of luck it should
just work...
Index: linux-work/init/main.c
===================================================================
--- linux-work.orig/init/main.c 2009-06-17 13:41:33.000000000 +1000
+++ linux-work/init/main.c 2009-06-17 13:41:45.000000000 +1000
@@ -546,6 +546,7 @@ static void __init mm_init(void)
page_cgroup_init_flatmem();
mem_init();
kmem_cache_init();
+ pgtable_cache_init();
vmalloc_init();
}
@@ -684,7 +685,6 @@ asmlinkage void __init start_kernel(void
late_time_init();
calibrate_delay();
pidmap_init();
- pgtable_cache_init();
anon_vma_init();
#ifdef CONFIG_X86
if (efi_enabled)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mm: Move pgtable_cache_init() earlier
2009-06-17 3:48 mm: Move pgtable_cache_init() earlier Benjamin Herrenschmidt
@ 2009-06-17 4:16 ` Pekka Enberg
0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2009-06-17 4:16 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Linus Torvalds, linux-mm, David S. Miller, Chris Zankel,
linuxppc-dev list
Hi Ben,
On Wed, Jun 17, 2009 at 6:48 AM, Benjamin
Herrenschmidt<benh@kernel.crashing.org> wrote:
> Some architectures need to initialize SLAB caches to be able
> to allocate page tables. They do that from pgtable_cache_init()
> so the later should be called earlier now, best is before
> vmalloc_init().
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Looks good to me!
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-17 4:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-17 3:48 mm: Move pgtable_cache_init() earlier Benjamin Herrenschmidt
2009-06-17 4:16 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox