From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 442B86B0083 for ; Fri, 12 Jun 2009 04:43:14 -0400 (EDT) Subject: Re: slab: setup allocators earlier in the boot sequence From: Benjamin Herrenschmidt In-Reply-To: <20090612080236.GB24044@wotan.suse.de> References: <200906111959.n5BJxFj9021205@hera.kernel.org> <1244770230.7172.4.camel@pasglop> <1244779009.7172.52.camel@pasglop> <1244780756.7172.58.camel@pasglop> <1244783235.7172.61.camel@pasglop> <1244792079.7172.74.camel@pasglop> <1244792745.30512.13.camel@penberg-laptop> <20090612075427.GA24044@wotan.suse.de> <1244793592.30512.17.camel@penberg-laptop> <20090612080236.GB24044@wotan.suse.de> Content-Type: text/plain Date: Fri, 12 Jun 2009 18:44:19 +1000 Message-Id: <1244796259.7172.86.camel@pasglop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Nick Piggin Cc: Pekka Enberg , Linus Torvalds , Linux Kernel list , linux-mm , mingo@elte.hu, cl@linux-foundation.org, akpm@linux-foundation.org List-ID: On Fri, 2009-06-12 at 10:02 +0200, Nick Piggin wrote: > Fair enough, but this can be done right down in the synchronous > reclaim path in the page allocator. This will catch more cases > of code using the page allocator directly, and should be not > as hot as the slab allocator. > Yes except that slab has explicit local_irq_enable() when __GFP_WAIT is set so we also need to deal with that for the boot case. But again, this is a lot less of an issue if you use my proposed patch instead which just applies a mask of "forbidden" bits rather than a conditional branch based on the system state. It will also allow for more fine grained masking out if we decide, for example, that at some stage we want to mask out GFP_IO etc... Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org