From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id AD4C56B005A for ; Fri, 12 Jun 2009 03:38:44 -0400 (EDT) Subject: Re: slab: setup allocators earlier in the boot sequence From: Benjamin Herrenschmidt In-Reply-To: <1244792079.7172.74.camel@pasglop> References: <200906111959.n5BJxFj9021205@hera.kernel.org> <1244770230.7172.4.camel@pasglop> <1244779009.7172.52.camel@pasglop> <1244780756.7172.58.camel@pasglop> <1244783235.7172.61.camel@pasglop> <1244792079.7172.74.camel@pasglop> Content-Type: text/plain Date: Fri, 12 Jun 2009 17:39:40 +1000 Message-Id: <1244792380.7172.77.camel@pasglop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Pekka J Enberg Cc: Linus Torvalds , Linux Kernel list , linux-mm , mingo@elte.hu List-ID: On Fri, 2009-06-12 at 17:34 +1000, Benjamin Herrenschmidt wrote: > I don't like that approach at all. Fixing all the call sites... we are > changing things all over the place, we'll certainly miss some, and > honestly, it's none of the business of things like vmalloc to know about > things like what kmalloc flags are valid and when... Oh and btw, your patch alone doesn't fix powerpc, because it's missing a whole bunch of GFP_KERNEL's in the arch code... You would have to grep the entire kernel for things that check slab_is_available() and even then you'll be missing some. For example, slab_is_available() didn't always exist, and so in the early days on powerpc, we used a mem_init_done global that is set form mem_init() (not perfect but works in practice). And we still have code using that to do the test. Anyway, I think changing all the call sites is the wrong approach, especially for things that can routinely be called after boot when GFP_KERNEL is the right thing to do. Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org