From: Mel Gorman <mel@csn.ul.ie>
To: Mel Gorman <mel@csn.ul.ie>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
yanmin.zhang@intel.com, Wu Fengguang <fengguang.wu@intel.com>,
linuxram@us.ibm.com
Cc: linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/3] [RFC] Functional fix to zone_reclaim() and bring behaviour more in line with expectations
Date: Mon, 8 Jun 2009 14:01:27 +0100 [thread overview]
Message-ID: <1244466090-10711-1-git-send-email-mel@csn.ul.ie> (raw)
A bug was brought to my attention against a distro kernel but it affects
mainline and I believe problems like this have been reported in various guises
on the mailing lists although I don't have specific examples at the moment.
The problem that was reported that led to this patchset was that malloc()
stalled for a long time (minutes in some cases) if a large tmpfs mount
was occupying a large percentage of memory overall. The pages did not get
cleaned or reclaimed by zone_reclaim() because the zone_reclaim_mode was
unsuitable, but the lists are uselessly scanned frequencly making the CPU
spin at near 100%.
I do not have the bug resolved yet although I believe patch 1 of this series
addresses it and am waiting to hear back from the bug reporter. However,
the fix should work two other patches in this series also should bring
zone_reclaim() more in line with expectations.
Patch 1 reintroduces zone_reclaim_interval to catch the situation where
zone_reclaim() cannot tell in advance that the scan is a waste
of time.
Patch 2 alters the heuristics that zone_reclaim() uses to determine if the
scan should go ahead. Currently, it is basically assuming
zone_reclaim_mode is 1
Patch 3 notes that zone_reclaim() returning a failure automatically means
the zone is marked full. This is not always true. It could have failed
because the GFP mask or zone_reclaim_mode are unsuitable. The patch
makes zone_reclaim() more careful about marking zones temporarily full
Note, this patchset has not been tested heavily.
Comments?
Documentation/sysctl/vm.txt | 13 +++++++++++
include/linux/mmzone.h | 9 ++++++++
include/linux/swap.h | 1 +
kernel/sysctl.c | 9 ++++++++
mm/internal.h | 4 +++
mm/page_alloc.c | 26 +++++++++++++++++++---
mm/vmscan.c | 48 +++++++++++++++++++++++++++++++++++++-----
7 files changed, 100 insertions(+), 10 deletions(-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-06-08 11:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 13:01 Mel Gorman [this message]
2009-06-08 13:01 ` [PATCH 1/3] Reintroduce zone_reclaim_interval for when zone_reclaim() scans and fails to avoid CPU spinning at 100% on NUMA Mel Gorman
2009-06-08 13:31 ` Rik van Riel
2009-06-08 13:54 ` Mel Gorman
2009-06-08 14:33 ` Christoph Lameter
2009-06-08 14:38 ` Mel Gorman
2009-06-08 14:55 ` Christoph Lameter
2009-06-08 15:11 ` Mel Gorman
2009-06-10 5:23 ` Andrew Morton
2009-06-10 6:44 ` KOSAKI Motohiro
2009-06-10 10:00 ` Mel Gorman
2009-06-08 14:48 ` Rik van Riel
2009-06-09 8:08 ` Mel Gorman
2009-06-09 1:58 ` Wu Fengguang
2009-06-09 8:14 ` Mel Gorman
2009-06-09 8:25 ` Wu Fengguang
2009-06-09 8:31 ` Mel Gorman
2009-06-09 9:07 ` Wu Fengguang
2009-06-09 9:40 ` Mel Gorman
2009-06-09 13:38 ` Wu Fengguang
2009-06-09 15:06 ` Mel Gorman
2009-06-10 2:14 ` Wu Fengguang
2009-06-10 9:54 ` Mel Gorman
2009-06-09 7:48 ` KOSAKI Motohiro
2009-06-09 8:18 ` Mel Gorman
2009-06-09 8:45 ` KOSAKI Motohiro
2009-06-09 9:42 ` Mel Gorman
2009-06-09 9:45 ` KOSAKI Motohiro
2009-06-09 9:59 ` KOSAKI Motohiro
2009-06-09 10:44 ` Mel Gorman
2009-06-09 10:50 ` KOSAKI Motohiro
2009-06-08 13:01 ` [PATCH 2/3] Properly account for the number of page cache pages zone_reclaim() can reclaim Mel Gorman
2009-06-08 14:25 ` Christoph Lameter
2009-06-08 14:36 ` Mel Gorman
2009-06-09 2:25 ` Wu Fengguang
2009-06-09 8:27 ` Mel Gorman
2009-06-09 8:45 ` Wu Fengguang
2009-06-09 10:48 ` Mel Gorman
2009-06-09 12:08 ` Wu Fengguang
2009-06-09 8:55 ` KOSAKI Motohiro
2009-06-09 2:37 ` Wu Fengguang
2009-06-09 8:19 ` KOSAKI Motohiro
2009-06-09 8:47 ` Mel Gorman
2009-06-08 13:01 ` [PATCH 3/3] Do not unconditionally treat zones that fail zone_reclaim() as full Mel Gorman
2009-06-08 14:32 ` Christoph Lameter
2009-06-08 14:43 ` Mel Gorman
2009-06-09 3:11 ` Wu Fengguang
2009-06-09 8:50 ` Mel Gorman
2009-06-09 7:48 ` KOSAKI Motohiro
2009-06-09 9:25 ` Mel Gorman
2009-06-09 12:05 ` KOSAKI Motohiro
2009-06-09 13:28 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244466090-10711-1-git-send-email-mel@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=riel@redhat.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox