From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 7DBCC6B005A for ; Thu, 4 Jun 2009 07:56:59 -0400 (EDT) Subject: Re: [patch] procfs: provide stack information for threads From: Stefani Seibold In-Reply-To: <20090604043750.e1031e01.akpm@linux-foundation.org> References: <1238511505.364.61.camel@matrix> <20090401193135.GA12316@elte.hu> <1244114628.31230.3.camel@wall-e> <20090604043750.e1031e01.akpm@linux-foundation.org> Content-Type: text/plain Date: Thu, 04 Jun 2009 13:56:29 +0200 Message-Id: <1244116589.32392.15.camel@wall-e> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: linux-kernel , linux-mm , Ingo Molnar , Joerg Engel , Thomas Gleixner List-ID: Am Donnerstag, den 04.06.2009, 04:37 -0700 schrieb Andrew Morton: > On Thu, 04 Jun 2009 13:23:48 +0200 Stefani Seibold wrote: > > - slime done > > What's "slime"? > Sorry, that was a typo, should be "slim down". > > + for (i = vma->vm_start; i+PAGE_SIZE <= stkpage; i += PAGE_SIZE) { > > + > > + page = follow_page(vma, i, 0); > > + > > + if (!IS_ERR(page) && page) > > Shouldn't this be !page? > No, this is correct... I walk through the top of vma to the first mapped page, this is the high water mark of the stack. > > + unsigned long stack_start; > > + > > + stack_start = > > + ((struct proc_maps_private *) > > + m->private)->task->stack_start; > > I'd suggested a clearer/cleaner way of implementing this. > Sorry, i can not see a problem here. In your last posting you wrote thats okay! And i have no idea how to make this expression clearer/cleaner. > > Signed-off-by: Stefani Seibold > > This should be positioned at the end of the changelog, ahead of the > patch itself. > Next time i will do this, okay? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org