From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Ron <ron@debian.org>
Cc: cl@linux-foundation.org, mpm@selenic.com, linux-mm@kvack.org,
akinobu.mita@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: fix generic PAGE_POISONING conflict with SLAB_RED_ZONE
Date: Fri, 22 May 2009 11:02:52 +0300 [thread overview]
Message-ID: <1242979372.13681.1.camel@penberg-laptop> (raw)
In-Reply-To: <20090521192822.GB4448@homer.shelbyville.oz>
On Fri, 2009-05-22 at 04:58 +0930, Ron wrote:
> A generic page poisoning mechanism was added with commit:
> 6a11f75b6a17b5d9ac5025f8d048382fd1f47377
> which destructively poisons full pages with a bitpattern.
>
> On arches where PAGE_POISONING is used, this conflicts with the slab
> redzone checking enabled by DEBUG_SLAB, scribbling bits all over its
> magic words and making it complain about that quite emphatically.
>
> On x86 (and I presume at present all the other arches which set
> ARCH_SUPPORTS_DEBUG_PAGEALLOC too), the kernel_map_pages() operation
> is non destructive so it can coexist with the other DEBUG_SLAB
> mechanisms just fine.
>
> This patch favours the expensive full page destruction test for
> cases where there is a collision and it is explicitly selected.
>
> Signed-off-by: Ron Lee <ron@debian.org>
Applied, thanks!
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-05-22 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 19:28 Ron
2009-05-22 8:02 ` Pekka Enberg [this message]
2009-05-22 8:50 ` [PATCH] slab: add missing guard for kernel_map_pages() use Ron
2009-05-22 10:17 ` Ron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242979372.13681.1.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=akinobu.mita@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=ron@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox