From: Alex Shi <alex.shi@linux.alibaba.com>
To: Michal Hocko <mhocko@suse.com>, Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, nao.horiguchi@gmail.com,
osalvador@suse.de, mike.kravetz@oracle.com
Subject: Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged
Date: Tue, 25 Aug 2020 09:25:01 +0800 [thread overview]
Message-ID: <12425e06-38ce-7ff4-28ce-b0418353fc67@linux.alibaba.com> (raw)
In-Reply-To: <20200824151013.GB3415@dhcp22.suse.cz>
reproduce using our linux-mm random bug collection on NUMA systems.
>>
>> OK, I must have missed that this was on ppc. The order makes more sense
>> now. I will have a look at this next week.
>
> OK, so I've had a look and I know what's going on there. The
> move_pages12 is migrating hugetlb pages. Those are not charged to any
> memcg. We have completely missed this case. There are two ways going
> around that. Drop the warning and update the comment so that we do not
> forget about that or special case hugetlb pages.
>
> I think the first option is better.
>
Hi Michal,
Compare to ignore the warning which is designed to give, seems addressing
the hugetlb out of charge issue is a better solution, otherwise the memcg
memory usage is out of control on hugetlb, is that right?
Thanks
Alex
next prev parent reply other threads:[~2020-08-25 1:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 11:10 Alex Shi
2020-08-11 11:10 ` [Resend PATCH 2/6] mm/memcg: remove useless check on page->mem_cgroup Alex Shi
2020-08-11 11:30 ` Michal Hocko
2020-08-11 12:42 ` Alex Shi
2020-08-11 12:54 ` Alex Shi
2020-08-11 13:56 ` Michal Hocko
2020-08-12 3:25 ` Alex Shi
2020-08-13 6:20 ` Michal Hocko
2020-08-13 9:45 ` Alex Shi
2020-08-13 11:01 ` Michal Hocko
2020-08-11 11:10 ` [Resend PATCH 3/6] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi
2020-08-11 11:10 ` [Resend PATCH 4/6] mm/thp: clean up lru_add_page_tail Alex Shi
2020-08-11 11:10 ` [Resend PATCH 5/6] mm/thp: remove code path which never got into Alex Shi
2020-08-11 11:10 ` [Resend PATCH 6/6] mm/thp: narrow lru locking Alex Shi
2020-08-20 14:58 ` [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Qian Cai
2020-08-21 8:01 ` Michal Hocko
2020-08-21 12:39 ` Qian Cai
2020-08-21 13:48 ` Michal Hocko
2020-08-24 15:10 ` Michal Hocko
2020-08-25 1:25 ` Alex Shi [this message]
2020-08-25 2:04 ` Hugh Dickins
2020-08-27 6:00 ` Hugh Dickins
2020-08-25 7:25 ` Michal Hocko
2020-08-24 14:52 ` Qian Cai
2020-08-24 15:10 ` Michal Hocko
2020-08-24 23:00 ` Stephen Rothwell
2020-08-24 23:14 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12425e06-38ce-7ff4-28ce-b0418353fc67@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox