From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 5AB386B003D for ; Wed, 29 Apr 2009 02:41:57 -0400 (EDT) Subject: Re: [PATCH] vmscan: evict use-once pages first From: Peter Zijlstra In-Reply-To: <20090428192907.556f3a34@bree.surriel.com> References: <20090428044426.GA5035@eskimo.com> <20090428192907.556f3a34@bree.surriel.com> Content-Type: text/plain Date: Wed, 29 Apr 2009 08:42:29 +0200 Message-Id: <1240987349.4512.18.camel@laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Rik van Riel Cc: Elladan , linux-kernel@vger.kernel.org, tytso@mit.edu, kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org List-ID: On Tue, 2009-04-28 at 19:29 -0400, Rik van Riel wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index eac9577..4c0304e 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1489,6 +1489,21 @@ static void shrink_zone(int priority, struct zone *zone, > nr[l] = scan; > } > > + /* > + * When the system is doing streaming IO, memory pressure here > + * ensures that active file pages get deactivated, until more > + * than half of the file pages are on the inactive list. > + * > + * Once we get to that situation, protect the system's working > + * set from being evicted by disabling active file page aging > + * and swapping of swap backed pages. We still do background > + * aging of anonymous pages. > + */ > + if (nr[LRU_INACTIVE_FILE] > nr[LRU_ACTIVE_FILE]) { > + nr[LRU_ACTIVE_FILE] = 0; > + nr[LRU_INACTIVE_ANON] = 0; > + } > + Isn't there a hole where LRU_*_FILE << LRU_*_ANON and we now stop shrinking INACTIVE_ANON even though it makes sense to. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org