From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 467986B0055 for ; Tue, 21 Apr 2009 03:12:56 -0400 (EDT) Subject: Re: [PATCH 05/25] Break up the allocator entry point into fast and slow paths From: Pekka Enberg In-Reply-To: <20090421150235.F12A.A69D9226@jp.fujitsu.com> References: <1240266011-11140-1-git-send-email-mel@csn.ul.ie> <1240266011-11140-6-git-send-email-mel@csn.ul.ie> <20090421150235.F12A.A69D9226@jp.fujitsu.com> Date: Tue, 21 Apr 2009 10:13:04 +0300 Message-Id: <1240297984.771.24.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Mel Gorman , Linux Memory Management List , Christoph Lameter , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra , Andrew Morton List-ID: Hi! On Tue, 2009-04-21 at 15:35 +0900, KOSAKI Motohiro wrote: > > The core of the page allocator is one giant function which allocates memory > > on the stack and makes calculations that may not be needed for every > > allocation. This patch breaks up the allocator path into fast and slow > > paths for clarity. Note the slow paths are still inlined but the entry is > > marked unlikely. If they were not inlined, it actally increases text size > > to generate the as there is only one call site. > > hmm.. > > this patch have few behavior change. > please separate big cleanup patch and behavior patch. > > I hope to make this patch non functional change. I'm not sure about these > are your intentional change or not. it cause harder reviewing... Agreed, splitting this patch into smaller chunks would make it easier to review. Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org