From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 0D6E96B0092 for ; Mon, 16 Mar 2009 05:44:30 -0400 (EDT) From: Mel Gorman Subject: [PATCH 19/35] Do not setup zonelist cache when there is only one node Date: Mon, 16 Mar 2009 09:46:14 +0000 Message-Id: <1237196790-7268-20-git-send-email-mel@csn.ul.ie> In-Reply-To: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> References: <1237196790-7268-1-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org To: Mel Gorman , Linux Memory Management List Cc: Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra List-ID: There is a zonelist cache which is used to track zones that are not in the allowed cpuset or found to be recently full. This is to reduce cache footprint on large machines. On smaller machines, it just incurs cost for no gain. This patch only uses the zonelist cache when there are NUMA nodes. Signed-off-by: Mel Gorman --- mm/page_alloc.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index a068589..e620c91 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1442,6 +1442,8 @@ get_page_from_freelist(gfp_t gfp_mask, nodemask_t *nodemask, unsigned int order, /* Determine in advance if the zonelist needs filtering */ if ((alloc_flags & ALLOC_CPUSET) && unlikely(number_of_cpusets > 1)) zonelist_filter = 1; + if (num_online_nodes() > 1) + zonelist_filter = 1; zonelist_scan: /* @@ -1486,8 +1488,12 @@ this_zone_full: zlc_mark_zone_full(zonelist, z); try_next_zone: if (NUMA_BUILD && zonelist_filter) { - if (!did_zlc_setup) { - /* do zlc_setup after the first zone is tried */ + if (!did_zlc_setup && num_online_nodes() > 1) { + /* + * do zlc_setup after the first zone is tried + * but only if there are multiple nodes to make + * it worthwhile + */ allowednodes = zlc_setup(zonelist, alloc_flags); zlc_active = 1; } -- 1.5.6.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org