From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, songmuchun@bytedance.com,
mike.kravetz@oracle.com, vbabka@suse.cz,
william.kucharski@oracle.com, dhowells@redhat.com,
peterx@redhat.com, arnd@arndb.de, ccross@google.com,
hughd@google.com, ebiederm@xmission.com
Subject: Re: [PATCH 1/7] mm/hugetlb: add folio support to hugetlb specific flag macros
Date: Tue, 30 Aug 2022 11:09:33 -0700 [thread overview]
Message-ID: <12303882-dd84-485a-28cb-cefbaac4d960@oracle.com> (raw)
In-Reply-To: <Yw2E937l+GARR3Vb@casper.infradead.org>
On 8/29/22 8:33 PM, Matthew Wilcox wrote:
> On Mon, Aug 29, 2022 at 04:00:08PM -0700, Sidhartha Kumar wrote:
>> #define TESTHPAGEFLAG(uname, flname) \
>> +static __always_inline \
>> +int folio_test_hugetlb_##flname(struct folio *folio) \
> One change I made was to have folio_test_foo() return bool instead of
> int. It helps the compiler really understand what's going on. Maybe
> some humans too ;-)
>
I went with returning an int to stay consistent with the page version
of the macros which return an int. I'm fine with changing it to return
a bool.
>> + { void **private = &folio->private; \
>> + return test_bit(HPG_##flname, (void *)((unsigned long)private)); \
> I've made this tricky for you by making folio->private a void * instead
> of the unsigned long in page. Would this look better as ...
>
> { \
> void *private = &folio->private; \
> return test_bit(HPG_##flname, private); \
>
> perhaps?
Ya this looks much better and passes the tests, will add to v2.
next prev parent reply other threads:[~2022-08-30 18:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 23:00 [PATCH 0/7] begin converting hugetlb code to folios Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 1/7] mm/hugetlb: add folio support to hugetlb specific flag macros Sidhartha Kumar
2022-08-30 3:33 ` Matthew Wilcox
2022-08-30 18:09 ` Sidhartha Kumar [this message]
2022-09-01 16:55 ` Mike Kravetz
2022-08-29 23:00 ` [PATCH 2/7] mm: add private field of first tail to struct page and struct folio Sidhartha Kumar
2022-08-30 3:36 ` Matthew Wilcox
2022-09-01 17:32 ` Mike Kravetz
2022-09-01 18:32 ` Matthew Wilcox
2022-09-01 20:29 ` Mike Kravetz
2022-08-29 23:00 ` [PATCH 3/7] mm/hugetlb: add hugetlb_folio_subpool() helper Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 4/7] mm/hugetlb: add hugetlb_set_folio_subpool() helper Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 5/7] mm/hugetlb: convert hugetlb_delete_from_page_cache() to use folios Sidhartha Kumar
2022-08-30 3:26 ` Matthew Wilcox
2022-08-30 16:47 ` Sidhartha Kumar
2022-08-29 23:00 ` [PATCH 6/7] mm/hugetlb add folio_hstate() Sidhartha Kumar
2022-09-01 18:34 ` Mike Kravetz
2022-08-29 23:00 ` [PATCH 7/7] mm/migrate: use folio_hstate() in alloc_migration_target() Sidhartha Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12303882-dd84-485a-28cb-cefbaac4d960@oracle.com \
--to=sidhartha.kumar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ccross@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox