* [BUGFIX][PATCH] memcg: memory hotplug fix
@ 2008-11-10 9:38 KAMEZAWA Hiroyuki
2008-11-10 15:52 ` Badari Pulavarty
0 siblings, 1 reply; 2+ messages in thread
From: KAMEZAWA Hiroyuki @ 2008-11-10 9:38 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-mm, pbadari, akpm
This is a bug fix reported against 2.6.28-rc3 from Badari.
Badari, could you give me Ack or Tested-by ?
Thanks,
-Kame
==
start pfn calculation of page_cgroup's memory hotplug notifier chain
is wrong.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
mm/page_cgroup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: mmotm-2.6.28-Oct30/mm/page_cgroup.c
===================================================================
--- mmotm-2.6.28-Oct30.orig/mm/page_cgroup.c
+++ mmotm-2.6.28-Oct30/mm/page_cgroup.c
@@ -165,7 +165,7 @@ int online_page_cgroup(unsigned long sta
unsigned long start, end, pfn;
int fail = 0;
- start = start_pfn & (PAGES_PER_SECTION - 1);
+ start = start_pfn & ~(PAGES_PER_SECTION - 1);
end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);
for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) {
@@ -188,7 +188,7 @@ int offline_page_cgroup(unsigned long st
{
unsigned long start, end, pfn;
- start = start_pfn & (PAGES_PER_SECTION - 1);
+ start = start_pfn & ~(PAGES_PER_SECTION - 1);
end = ALIGN(start_pfn + nr_pages, PAGES_PER_SECTION);
for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUGFIX][PATCH] memcg: memory hotplug fix
2008-11-10 9:38 [BUGFIX][PATCH] memcg: memory hotplug fix KAMEZAWA Hiroyuki
@ 2008-11-10 15:52 ` Badari Pulavarty
0 siblings, 0 replies; 2+ messages in thread
From: Badari Pulavarty @ 2008-11-10 15:52 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: linux-kernel, linux-mm, akpm
On Mon, 2008-11-10 at 18:38 +0900, KAMEZAWA Hiroyuki wrote:
> This is a bug fix reported against 2.6.28-rc3 from Badari.
> Badari, could you give me Ack or Tested-by ?
>
> Thanks,
> -Kame
> ==
> start pfn calculation of page_cgroup's memory hotplug notifier chain
> is wrong.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Tested-by: Badari Pulavarty <pbadari@us.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-10 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-10 9:38 [BUGFIX][PATCH] memcg: memory hotplug fix KAMEZAWA Hiroyuki
2008-11-10 15:52 ` Badari Pulavarty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox