linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Hugh Dickins <hugh@veritas.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH next 2/3] slub defrag: dma_kmalloc_cache add_tail
Date: Mon, 06 Oct 2008 10:46:47 +0300	[thread overview]
Message-ID: <1223279207.30581.2.camel@penberg-laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0810050325440.22004@blonde.site>

On Sun, 2008-10-05 at 03:27 +0100, Hugh Dickins wrote:
> Why did that slowdown from mispinned pages manifest only on the G5?
> 
> Because something in my x86_32 and x86_64 configs (CONFIG_BLK_DEV_SR
> I believe) is giving me a kmalloc_dma-512 cache, and dma_kmalloc_cache()
> had not been updated to satisfy the assumption in kmem_cache_defrag(),
> that defragmentable caches come first in the list.
> 
> So, any DMAable cache was preventing all slub defragmentation: which
> looks like it's not been getting the testing exposure it deserves.
> 
> Signed-off-by: Hugh Dickins <hugh@veritas.com>

Applied, thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-10-06  7:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-05  2:25 [PATCH next 1/3] slub defrag: unpin writeback pages Hugh Dickins
2008-10-05  2:27 ` [PATCH next 2/3] slub defrag: dma_kmalloc_cache add_tail Hugh Dickins
2008-10-06  7:46   ` Pekka Enberg [this message]
2008-10-07 13:25     ` Christoph Lameter
2008-10-05  2:28 ` [PATCH next 3/3] slub defrag: slabinfo help trivia Hugh Dickins
2008-10-06  7:40   ` Pekka Enberg
2008-10-06  7:53 ` [PATCH next 1/3] slub defrag: unpin writeback pages Pekka Enberg
2008-10-07 13:24 ` Christoph Lameter
2008-10-07 15:34   ` Hugh Dickins
2008-10-07 15:41     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223279207.30581.2.camel@penberg-laptop \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox