From: Peter Zijlstra <peterz@infradead.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-mm <linux-mm@kvack.org>, Nick Piggin <nickpiggin@yahoo.com.au>
Subject: nfs mmap vs i_mutex inversion
Date: Thu, 02 Oct 2008 16:53:35 +0200 [thread overview]
Message-ID: <1222959215.27875.8.camel@twins> (raw)
Hi Trond,
About that lock order inversion I remembered, I still have the patches:
http://programming.kicks-ass.net/kernel-patches/mmap-vs-nfs/
Although they would want updating a little.
But looking at a recent (.27-rc5-mm1) the offending code path:
down_write(&mm->mmap_sem)
...
->nfs_file_mmap()
nfs_revalidate_mapping()
nfs_invalidate_mapping()
mutex_lock(&inode->i_mutex);
vs the regular order of
inode->i_mutex
mm->mmap_sem
as described in mm/rmap.c
Seems to still exist.
If you agree its a valid concern, I'll brush up the patches and repost.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2008-10-02 14:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222959215.27875.8.camel@twins \
--to=peterz@infradead.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox