From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Gary Hade <garyhade@us.ibm.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Badari Pulavarty <pbadari@us.ibm.com>, Mel Gorman <mel@csn.ul.ie>,
Chris McDermott <lcm@us.ibm.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Greg KH <greg@kroah.com>,
Nish Aravamudan <nish.aravamudan@gmail.com>
Subject: Re: [PATCH] mm: show node to memory section relationship with symlinks in sysfs
Date: Tue, 30 Sep 2008 08:50:37 -0700 [thread overview]
Message-ID: <1222789837.17630.41.camel@nimitz> (raw)
In-Reply-To: <20080930163324.44A7.E1E9C6FF@jp.fujitsu.com>
On Tue, 2008-09-30 at 17:06 +0900, Yasunori Goto wrote:
> > +#define section_nr_to_nid(section_nr) pfn_to_nid(section_nr_to_pfn(section_nr))
> > #endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */
>
> If the first page of the section is not valid, then this section_nr_to_nid()
> doesn't return correct value.
>
> I tested this patch. In my box, the start_pfn of node 1 is 1200400, but
> section_nr_to_pfn(mem_blk->phys_index) returns 1200000. As a result,
> the section is linked to node 0.
Crap, I was worried about that.
Gary, this means that we have a N:1 relationship between NUMA nodes and
sections. This normally isn't a problem because sections don't really
care about nodes and they layer underneath them.
We'll probably need multiple symlinks in each section directory.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-30 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 20:05 Gary Hade
2008-09-30 8:06 ` Yasunori Goto
2008-09-30 15:50 ` Dave Hansen [this message]
2008-09-30 19:41 ` Gary Hade
2008-10-01 2:48 ` Yasunori Goto
2008-10-01 16:51 ` Gary Hade
2008-09-30 23:29 ` Gary Hade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222789837.17630.41.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=garyhade@us.ibm.com \
--cc=greg@kroah.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=nish.aravamudan@gmail.com \
--cc=pbadari@us.ibm.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox