From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, rppt@linux.ibm.com, will@kernel.org,
aneesh.kumar@linux.ibm.com, npiggin@gmail.com,
peterz@infradead.org, catalin.marinas@arm.com,
chenhuacai@kernel.org, kernel@xen0n.name,
tsbogend@alpha.franken.de, dave.hansen@linux.intel.com,
luto@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, arnd@arndb.de, guoren@kernel.org,
monstr@monstr.eu, jonas@southpole.se,
stefan.kristiansson@saunalahti.fi, shorne@gmail.com,
x86@kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, linux-csky@vger.kernel.org,
openrisc@lists.librecores.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: Add kernel PTE level pagetable pages account
Date: Thu, 7 Jul 2022 19:45:29 +0800 [thread overview]
Message-ID: <12227412-1d79-4ff6-b4e6-0d438dac7359@linux.alibaba.com> (raw)
In-Reply-To: <YsWuC9+b3JaEAr0Q@casper.infradead.org>
On 7/6/2022 11:45 PM, Matthew Wilcox wrote:
> On Wed, Jul 06, 2022 at 04:59:17PM +0800, Baolin Wang wrote:
>> Now the kernel PTE level ptes are always protected by mm->page_table_lock
>> instead of split pagetable lock, so the kernel PTE level pagetable pages
>> are not accounted. Especially the vmalloc()/vmap() can consume lots of
>> kernel pagetable, so to get an accurate pagetable accounting, calling new
>> helpers page_{set,clear}_pgtable() when allocating or freeing a kernel
>> PTE level pagetable page.
>>
>> Meanwhile converting architectures to use corresponding generic PTE pagetable
>> allocation and freeing functions.
>>
>> Note this patch only adds accounting to the page tables allocated after boot.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> Reported-by: kernel test robot <oliver.sang@intel.com>
>
> What does this Reported-by: even mean? the kernel test robot told you
> that the page tables weren't being accounted?
I fixed an issue reported by this robot. OK, I can remove the tag.
> I don't understand why we want to start accounting kernel page tables.
> an we have a *discussion* about that with a sensible thread name instead
> of just trying to sneak it in as patch 3/3?
I think I have replied to you in below link [1]. The reason is we should
keep consistent with PMD or PUD pagetable allocation.
[1]
https://lore.kernel.org/all/68a5286b-7ff3-2c4e-1ab2-305e7860a2f3@linux.alibaba.com/
next prev parent reply other threads:[~2022-07-07 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 8:59 [PATCH 0/3] Add PUD and kernel PTE level pagetable account Baolin Wang
2022-07-06 8:59 ` [PATCH 1/3] mm: Factor out the pagetable pages account into new helper function Baolin Wang
2022-07-06 8:59 ` [PATCH 2/3] mm: Add PUD level pagetable account Baolin Wang
2022-07-06 8:59 ` [PATCH 3/3] mm: Add kernel PTE level pagetable pages account Baolin Wang
2022-07-06 15:45 ` Matthew Wilcox
2022-07-07 11:45 ` Baolin Wang [this message]
2022-07-06 15:48 ` [PATCH 0/3] Add PUD and kernel PTE level pagetable account Dave Hansen
2022-07-07 11:32 ` Baolin Wang
2022-07-07 14:44 ` Dave Hansen
2022-07-10 11:19 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12227412-1d79-4ff6-b4e6-0d438dac7359@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=jonas@southpole.se \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=loongarch@lists.linux.dev \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=npiggin@gmail.com \
--cc=openrisc@lists.librecores.org \
--cc=peterz@infradead.org \
--cc=rppt@linux.ibm.com \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox