From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: kamezawa.hiroyu@jp.fujitsu.com
Cc: linux-mm@kvack.org, balbir@linux.vnet.ibm.com,
nishimura@mxp.nes.nec.co.jp, xemul@openvz.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page)
Date: Mon, 22 Sep 2008 18:06:31 +0200 [thread overview]
Message-ID: <1222099591.16700.39.camel@lappy.programming.kicks-ass.net> (raw)
In-Reply-To: <22188426.1222099453986.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, 2008-09-23 at 01:04 +0900, kamezawa.hiroyu@jp.fujitsu.com wrote:
> ----- Original Message -----
> >On Mon, 2008-09-22 at 20:12 +0900, KAMEZAWA Hiroyuki wrote:
> >
> >> - all page_cgroup struct is maintained by hash.
> >> I think we have 2 ways to handle sparse index in general
> >> ...radix-tree and hash. This uses hash because radix-tree's layout is
> >> affected by memory map's layout.
> >
> >Could you provide further detail? That is, is this solely because our
> >radix tree implementation is sucky for large indexes?
> >
> no, sparse-large index.
>
> >If so, I did most of the work of fixing that, just need to spend a
> >little more time to stabalize the code.
> >
>
> IIUC, radix tree's height is determined by how sparse the space is.
Right, so Yes. Its that which I fixed.
> Then, steps to reach entries is tend to be larger than hash.
> I'm sorry if I misunderstood.
No problems,. I'll try and brush up that radix tree code and post
sometime soon.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-09-22 16:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 10:51 [PATCH 0/13] memory cgroup updates v4 KAMEZAWA Hiroyuki
2008-09-22 10:55 ` [PATCH 1/13] memcg: avoid accounting special mapping KAMEZAWA Hiroyuki
2008-09-22 10:57 ` [PATCH 2/13] memcg: account fault-in swap under lock KAMEZAWA Hiroyuki
2008-09-22 10:58 ` [PATCH 3/13] memcg: nolimit root cgroup KAMEZAWA Hiroyuki
2008-09-22 11:00 ` [PATCH 4/13] memcg: force_empty moving account KAMEZAWA Hiroyuki
2008-09-22 14:23 ` Peter Zijlstra
2008-09-22 14:50 ` kamezawa.hiroyu
2008-09-22 14:56 ` Peter Zijlstra
2008-09-22 15:06 ` kamezawa.hiroyu
2008-09-22 15:32 ` Peter Zijlstra
2008-09-22 15:43 ` kamezawa.hiroyu
2008-09-22 11:02 ` [PATCH 5/13] memcg: cleanup to make mapping null before unchage KAMEZAWA Hiroyuki
2008-09-22 11:03 ` [PATCH 6/13] memcg: optimze per cpu accounting for memcg KAMEZAWA Hiroyuki
2008-09-22 11:05 ` [PATCH 3.5/13] memcg: make page_cgroup flags to be atomic KAMEZAWA Hiroyuki
2008-09-22 11:09 ` [PATCH 3.6/13] memcg: add function to move account KAMEZAWA Hiroyuki
2008-09-24 6:50 ` Daisuke Nishimura
2008-09-24 7:11 ` KAMEZAWA Hiroyuki
2008-09-22 11:12 ` [PATCH 9/13] memcg: lookup page cgroup (and remove pointer from struct page) KAMEZAWA Hiroyuki
2008-09-22 14:52 ` Dave Hansen
2008-09-22 15:14 ` kamezawa.hiroyu
2008-09-22 15:47 ` Dave Hansen
2008-09-22 15:57 ` kamezawa.hiroyu
2008-09-22 16:10 ` Dave Hansen
2008-09-22 17:34 ` kamezawa.hiroyu
2008-09-22 15:47 ` Peter Zijlstra
2008-09-22 16:04 ` kamezawa.hiroyu
2008-09-22 16:06 ` Peter Zijlstra [this message]
2008-09-23 23:48 ` KAMEZAWA Hiroyuki
2008-09-24 2:09 ` Balbir Singh
2008-09-24 3:09 ` KAMEZAWA Hiroyuki
2008-09-24 8:31 ` Balbir Singh
2008-09-24 8:46 ` KAMEZAWA Hiroyuki
2008-09-22 11:13 ` [PATCH 10/13] memcg: page_cgroup look aside table KAMEZAWA Hiroyuki
2008-09-22 11:17 ` [PATCH 11/13] memcg: lazy LRU free (NEW) KAMEZAWA Hiroyuki
2008-09-22 11:22 ` [PATCH 12/13] memcg: lazy LRU add KAMEZAWA Hiroyuki
2008-09-22 11:24 ` [PATCH 13/13] memcg: swap accounting fix KAMEZAWA Hiroyuki
2008-09-22 11:28 ` [PATCH 0/13] memory cgroup updates v4 KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222099591.16700.39.camel@lappy.programming.kicks-ass.net \
--to=a.p.zijlstra@chello.nl \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox