From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F409AC18E7C for ; Wed, 26 Feb 2025 15:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E189280012; Wed, 26 Feb 2025 10:42:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 890E228000F; Wed, 26 Feb 2025 10:42:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70A6B280012; Wed, 26 Feb 2025 10:42:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4ED9B28000F for ; Wed, 26 Feb 2025 10:42:56 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CAB78C1758 for ; Wed, 26 Feb 2025 15:42:54 +0000 (UTC) X-FDA: 83162513868.21.DF5F5AE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 17126100012 for ; Wed, 26 Feb 2025 15:42:51 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="NsC51dH/"; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740584572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ct1usEIE5mCrQ0cI4Z5Fw7l48vyi/uJCgaNsySRiXLc=; b=nsDnGxwK12I+NOt/T/Llul9O6Pzm8njrTYFvzpIOtE4B/kSAmdu2XOD7Ng7/l1+Dp+HUm2 b180YcvqGBiMUhwMhyGWZ9VemJdlJoOWq0AD7MSd1+xRIawY8+Ja3PV+HDaXoygaQ+kvPP U4vvQfkWaFWUtkK2UAPTdxF6dzhDT9U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="NsC51dH/"; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740584572; a=rsa-sha256; cv=none; b=T5xgZb4bh39py7urec/8D0ihVSr2OWrbD/WKkz6i5+jArmu8BLpQcwoP+4pX6BgSC4AMuQ VG7KZ+y8g4YHI8vf5LiM5/0VwmD8cbn48ncT8dyQLyFj5y0gYEFL5c2RblmtNuyXc/QtSj XkmXdQxZK1+xGLy9QmYNeNYPBDMQLa8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740584571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ct1usEIE5mCrQ0cI4Z5Fw7l48vyi/uJCgaNsySRiXLc=; b=NsC51dH/oZTQ0mvKHrTT/TyHEwY2M1qgPxPHrNlgX4gIBh+YIJZ53OFYFB1YKVtG6/p5r+ F0EBt8FgAEH394pTHdi6vH/I5rZ3T7916NW7e62FaI++sJBTHboBOqtzvx8riwzch8+/NT DJEZgZ7A7jIrFp7J9b/Xz/3jmFPQ4as= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-BzI06yXkMv-nOBd8nKUxJw-1; Wed, 26 Feb 2025 10:42:50 -0500 X-MC-Unique: BzI06yXkMv-nOBd8nKUxJw-1 X-Mimecast-MFC-AGG-ID: BzI06yXkMv-nOBd8nKUxJw_1740584569 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-390ddb832e6so329483f8f.1 for ; Wed, 26 Feb 2025 07:42:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740584569; x=1741189369; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ct1usEIE5mCrQ0cI4Z5Fw7l48vyi/uJCgaNsySRiXLc=; b=v+L9DiLbpeylOqqI/A6B1YRTjUZhgX/Xb0daxr/vKO0JMC2nvjKLf5jjECpOVJuIHP DMnNaNMnzay5RiTM+5IN4BpZLYVMQpst7Y/0hsQCVGJmv/VU6m5WWvX/fh4CIH5EcKTJ yVf5NftyZY3dYzPbGBHORIgRHP4bJ7k6BVnAFVL68efcCyBUYlYtV4BleNs2UsuqFSN1 li+14uyQlqf3QZ87ZaBqQ0/e8kb9+7Y8OFq5IuycTyX8M9IfxzY4K+Ed5qQjE+vs9PCj AT66y0WnELGh8n9GDCqSTa+DGwWnoF5+Cs+kORLWQMjtyzZhjFGeZStIlHAxL3L06kXJ JekA== X-Forwarded-Encrypted: i=1; AJvYcCXrW01a2kvPM9hZA+QvY2OWK+SC+DnLRansLTPyd0PlaAkoCmwQQtgfOvMdl5XDELhDtP0P3GS71Q==@kvack.org X-Gm-Message-State: AOJu0YxUMt/vdrgOiJC9nrCTa5+XIskKMhPU2ZHiArQPothabzW4X5mh V2O1ldcPHEXgZOXSm+8ZS28KkReBtS6rhhp5GXB+VzmV4TUOLCsf88GpsEkjPEiPnhrik3EPeBX Jge68zmpRI4uFhZcIcYqPf0NItyK+HvOBJuHxAKPb0VTSQb3A X-Gm-Gg: ASbGncuKI2hf2am7M00zqwluT1tsKgI9mX8oL/vbn8EAOrpRsXODVPqEyvhSN3E+lfW hGUC0cu06oUcjdGOjFFAWoRK/o8LCOG9q/7/HcI3locZrSsBzeRWUPJrkyfLw6XfSHHB0c41LRh BYh0qphxYQDxBX8grXHjpH5rCcwzztP1hAsi4WEoo0wJ2PiArM6Kvw8VnQ+KqhKWRNgjlx5XaCD mgxP0kI3AvJkMFR1O6u9UkwtJXxCyfyS50pdFcLrwD6/tCiSvYh6juJYXtZgMCVfsybJrkCIVF9 70ok9/M2f70HeXN1Gqc2es/a9xYxvmTJ5liWmVlIksZyj8B7w6gnjR4B4cEgHvNSTWBOyYbr499 Pdjogqdzi+nUGCxntpnN6z2RJC3b230sGjYuhvSGoOJM= X-Received: by 2002:a05:6000:18ad:b0:38f:2766:759f with SMTP id ffacd0b85a97d-390d4f8b640mr3418220f8f.41.1740584568849; Wed, 26 Feb 2025 07:42:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHc5f9sSVXsb/drkwgCC3GgZAvsBZeyAI1Ocx1CUODtH/g4ViRNzrq1fZFuXosu2Ho0LLxVFA== X-Received: by 2002:a05:6000:18ad:b0:38f:2766:759f with SMTP id ffacd0b85a97d-390d4f8b640mr3418195f8f.41.1740584568465; Wed, 26 Feb 2025 07:42:48 -0800 (PST) Received: from ?IPV6:2003:cb:c747:ff00:9d85:4afb:a7df:6c45? (p200300cbc747ff009d854afba7df6c45.dip0.t-ipconnect.de. [2003:cb:c747:ff00:9d85:4afb:a7df:6c45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390cd8fcca2sm6029159f8f.96.2025.02.26.07.42.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 07:42:48 -0800 (PST) Message-ID: <121abab9-5090-486b-a3af-776a9cae04fb@redhat.com> Date: Wed, 26 Feb 2025 16:42:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix finish_fault() handling for large folios To: Matthew Wilcox , Brian Geffon Cc: Andrew Morton , Zi Yan , Kefeng Wang , Suren Baghdasaryan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Baolin Wang , Hugh Dickins , Marek Maslanka References: <20250226114815.758217-1-bgeffon@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: j37v_YprXN_K9GuuTcJKbSQKS2icbA3yfmsYjl0_-c0_1740584569 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 17126100012 X-Stat-Signature: d9oz3dkpfxmzgk3mnzzgzjcwa7aarmwo X-Rspamd-Server: rspam03 X-HE-Tag: 1740584571-943094 X-HE-Meta: U2FsdGVkX18eJ0iIa7DGVQOaQ6JIgcwT/gsjA7ubNwfrFkIevrdev0Ujh/dH0nM/pe3SH2Kn/agi5hhpndItavWHsKQ9eNsBG4beohtDMVgjoE2eVrDPdbVc3OmDUNGfkneX6Ln84Y07IucAeizXmDH/bxMOMMMnSSRkGglyEfHkQkIZYtC8c3w1dVM+k4GRmjhXVs+9HDkaWw3Lb2nl9tRsuC7BZYcs0nctuvbUyFmCNq7cpi6zGnZlRBrc/kvC+6VJbKIPrKkUjKJpIMSl5HAVz7ckBLJERkP/thS6W9lTxbYReCbfdeFqtparwRxdIk7KYdMuKQxwECRUAG2S/KAy0Kt/ViBhqyUWFZzUFjjtj/J/CgC4m2fNo7RffCNYWzaseO370YIIerKgYeXRczQylMvgeRNQcLDarf223EOrPIeDIzB3kxKy1sOZCuHrUfwJCSqdLc1ADEBbANRcyyf9cIBBBxUsqMc9FnfvVb2vMqjpXBAGEunD/5kdcwVpgGFxsfor+zkv7kTr/bqrSi9Xvr8VrU4dyGVQXcP/BXU6YGFIp4kid4BcrsQyfTldyBtw2Kt5EuJ2yQ+bwunMncBvp9VYqhNPbxFIuKF34OLpBvFObuSBP2eqcddaexIcXa58qI/3Xe9toBpfDmMx+OJ54XEIKpGcod7cEbDz021uBWuQpblBhkdSmPSjIB5lJKNNWDp8XujWafWsXA9qpQdo/NrzS9kAnNMOKzasnv1oG8dyeFgKiP69Or1MdxPJz9apgfww/aOOKeyzzVXr83/pRl7uT9/pEXT7GjWm2yajv0Q9G7bFeydAn9P6P4Xb4JJ9pAm6d/ZxAdSuYFIMkPH1bDmQ4OhfTLPjRX9Bc7kfrAgT6hfX2GMhsfEXiacwazd/w/UT+atHY959bdIdROlzSHVw1q97rF3T3yusLvemNcGrcYbYf+25tGazWrnIAmfDkdoHCiwHr5+WNFL DYrLFbC0 CypAvVPo+KuSWSLr2A0jSsZqdIS/lqc9UJVPQr71WHDGP+aS0m+yILjIwu88XRt56eUsTOWTukNfOPpqMmHt/cAe/UEtj10zhaamfPuyhIlmfKlN5hGq9Ca8efMAL3Dgy6LQqrqSxvqKfP0RgolGSdNULBcwhPEc50qlvtkgJS/Wlglnkz8B2FUQSyUqwvDeIPsWIoh034VRk5edM7392vzo7QY2sYQbBZaOTcdmBMsUlJyINzUJag5BRW+outgzldXCZp34hRaEOGLzFzPsIgI2+c8YRwFb+bhmnYdk5kU9/t2h6V3m+UBSeW6uQf8VoSyVYy3t9YA8Nfhg87Il4DGEG4iJdyRF6CFxiLpny4n/v35vqrnmfABOjl3DLUqFWoq5Ehi08nWiPv5lZR0t3gjjP+/66yhFebG5gX1G+kni6tAYJ2hkT1U4PTeNWia8S05ABsmUHHN2aozC5VQ088AP3DTjZMqwnwLDaH3wIFixsAJrV/Lktf1XllhQWhHG4c+Xn4yvAbtDiEDcR6WLFqIcIGzgFM51yWwf0LXdE1N2+M7Dsp41cLlMN9m1tfiiD4xWZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.02.25 15:03, Matthew Wilcox wrote: > On Wed, Feb 26, 2025 at 06:48:15AM -0500, Brian Geffon wrote: >> When handling faults for anon shmem finish_fault() will attempt to install >> ptes for the entire folio. Unfortunately if it encounters a single >> non-pte_none entry in that range it will bail, even if the pte that >> triggered the fault is still pte_none. When this situation happens the >> fault will be retried endlessly never making forward progress. >> >> This patch fixes this behavior and if it detects that a pte in the range >> is not pte_none it will fall back to setting just the pte for the >> address that triggered the fault. > > Surely there's a similar problem in do_anonymous_page()? I recall we handle it in there correctly the last time I stared at it. We check pte_none to decide which folio size we can allocate (including basing the decision on other factors like VMA etc), and after retaking the PTL, we recheck vmf_pte_changed / pte_range_none() to make sure there were no races. -- Cheers, David / dhildenb