From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3619CDB474 for ; Sat, 21 Oct 2023 01:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3ACDA280012; Fri, 20 Oct 2023 21:40:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35CDF8D0008; Fri, 20 Oct 2023 21:40:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224D5280012; Fri, 20 Oct 2023 21:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 111568D0008 for ; Fri, 20 Oct 2023 21:40:11 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D65AA160BC5 for ; Sat, 21 Oct 2023 01:40:10 +0000 (UTC) X-FDA: 81367762980.30.B4495E1 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf09.hostedemail.com (Postfix) with ESMTP id 3C0F014000D for ; Sat, 21 Oct 2023 01:40:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=none (imf09.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697852408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0W96KZMhNooCApgVjULRJ0aTTVHKrmXAm7Q/IqNaFo=; b=RLBE4xbKqW16Xbo9JDN6f0L+3y1psV0lzogL8UGjE1/faKzv7eabH0JydQKz+f9YPusQCG 6h1nDT7IYJi7/3KBaShFe0RsSVMM4Vqk5l9KTmuIB3iVo7GRAcIyaXcqkvQcizot5WEj0f 9ixxkqok7xr4UNAllQPIO33PhBRmIlI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697852408; a=rsa-sha256; cv=none; b=K8QaK6hcQZchSWrUm4Gcceq1rRtI7wMFgDQq+G4VKF/i6LaArw8E604Cw9jVcdfl/YxjRJ vLmEkoqNJ8Ug4OGvqGtQtSE5+fhisfd6iwug2tG16sfjI//vPgCxrbdijqa1ZoaH7gqV9Y r2PM6T2LP3PtYgJRptaCKQcLOKgAAcU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=none (imf09.hostedemail.com: domain of houtao@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=houtao@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4SC3YC6H19z4f3l8F for ; Sat, 21 Oct 2023 09:20:31 +0800 (CST) Received: from [10.174.176.117] (unknown [10.174.176.117]) by APP1 (Coremail) with SMTP id cCh0CgDnbK1dJzNl6CFZDQ--.60283S2; Sat, 21 Oct 2023 09:20:33 +0800 (CST) Subject: Re: [PATCH bpf-next v3 2/7] mm/percpu.c: introduce pcpu_alloc_size() To: Alexei Starovoitov , Dennis Zhou Cc: bpf , linux-mm , Martin KaFai Lau , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , Hou Tao , Tejun Heo , Christoph Lameter , Andrew Morton References: <20231020133202.4043247-1-houtao@huaweicloud.com> <20231020133202.4043247-3-houtao@huaweicloud.com> From: Hou Tao Message-ID: <12196815-c2ed-b5cb-4bda-bee794d8d082@huaweicloud.com> Date: Sat, 21 Oct 2023 09:20:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:cCh0CgDnbK1dJzNl6CFZDQ--.60283S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Aw1UtF1rWr1DJr1Utry3twb_yoW8Xr18pF 1Yqayqyr4qk398C3Z2va1xCw1YvaySvr1fu3yYqrnavF9Ivrn2qr4DC3y3uFy3Jrn3Cw1j vrWqqF9rA34DZFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a 6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE 14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf 9x07UZ18PUUUUU= X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 3C0F014000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: m3jgatm5oczu7ngmgd17iym1zpkj99nu X-HE-Tag: 1697852406-411979 X-HE-Meta: U2FsdGVkX1+/lRs/EcPMlvtwXbQ+NVHr0Z0plRoa30SoBLEJTzi/H+HXKU158PBviGP28SNVPTfbTca0KCOl6/QIse+yjNFcW9XjkTKkcW3BR5LaARc4zYSk8wmGxAR07AfhJjmk2CwXrBM6qqAEiIJoDoIZmIbtg1ZIrULS3M/Uah1x1klASHi/KNmjgGP2ewhaDo9eeRiVUsJFwLsjtPrUlxZZT87y3jF/a0nA9itEXyQloxL80hgsmfKZjQMrieUkkIwCbsaje+yVjbfrTSRRskqLTkWz7OlDK3scX9BwUlyOteM33wJbRF3Uys1DaeXhvie50q89IeVKN/Fku3GS3IhH9pGYPP5ODF5NrRBJ/yMAOwu7O487U6Zfd8FMcfAbF4Ma4REEBB5lEHnWL67qdT0m7/H6Bc1DvuLTepxus/hX51FJjjyYNSiyeu+98k+Jckl5LEd6HHRDn23N8K5+3Sz8Phs6ompVgxiRJ3cELUCNs1ezef8bJeOxZpKwRC5iZpm4BxCY9sUBwi+W/gedlTqPn/DBx7gyTJpEVZyLKvfnzCmkV7vQ9+ePzWIDxafLxwbaZpExUqz6KVojHT9uHFnoG1nvFRXVbLpqQ9iULDovNnrc0WvjezKkufmWD7fg2bTk1o421ofnORzXAgcuZNCyeLE27gy5NhHTrNBehNvp8t2kmg9gcnMX1BJF+SiP9m4KTOKl9Gopl0UocijpJdR6rz5niXE0qN5pb9HVFaobgb88C8g0HqqgGr0rlBdldyXHrkUP19/NPvAxQkr/ot8L9li0faI793bZOcLyRe+wN0ie276vKU+ztZviES/BHq/2ikq81Fzo9tccb4zTeIHya3iDnCTCaU1L52Wdylxl4suMTPq+mqfM9qcqg6iv4pZnggBBD9L6iX4EpW/tX7Hu6id3PWYFUVxOcMetlRtKvnjY84er37MByqiyuKV29T5T5HE1xKhSjKu cboYfSiv B4/bxS+Sn3mXmUQoIc3U14xqho49yylOueWFAxvSz2K3G3r9NB+P/0CmixDNMYvPFLmXKwMctrdrHtlOOXyyD1+Eb1vaPHUjs06eUeXwfLL/FH/oM+9cGj1eXiTH3XfOfDF/WQljTmhGOkzJgjPFUCkMqOoHNL0+2HSJekynsMp2O5dMluCi3n7A3kABZTNUce11qROQKZR5TrX2P3iAhmhVwWLFhfj5Giqud/SU4Dp3Hne5ivxqgKxJMbYFKJ9W/awZn248nrSLPBvmQOgvxnKFzC5bWZFlPEvmlap3L5MC9i71XRc/7pQg06VR5okilCqFDNh5o1bOt1ISiC4GmoBnYVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 10/21/2023 5:17 AM, Alexei Starovoitov wrote: > On Fri, Oct 20, 2023 at 11:03 AM Dennis Zhou wrote: >> On Fri, Oct 20, 2023 at 10:58:37AM -0700, Alexei Starovoitov wrote: >>> On Fri, Oct 20, 2023 at 10:48 AM Dennis Zhou wrote: >>>> On Fri, Oct 20, 2023 at 09:31:57PM +0800, Hou Tao wrote: >>>>> From: Hou Tao >>>>> SNIP >>>>> + * >>>>> + * Returns the size of the @ptr allocation. This is undefined for statically >>>> ^ >>>> >>>> Nit: Alexei, when you pull this, can you make it a double space here? >>>> Just keeps percpu's file consistent. >>> Argh. Already applied. >>> That's a very weird style you have in a few places. >>> $ grep '\. [A-z]' mm/*.c|wc -l >>> 1118 >>> $ grep '\. [A-z]' mm/*.c|wc -l >>> 2451 >>> >>> Single space is used more often in mm/* and in the rest of the kernel. >>> >>> $ grep '\. [A-z]' mm/percpu.c|wc -l >>> 10 >>> >>> percpu.c isn't consistent either. >>> >>> I can force push if you really insist. >> Eh, if it's trouble I can fix it in the future. I know single space is >> more common, but percpu was written with double so I'm trying my best to >> keep the file consistent. > Ok. Fair enough. > Force pushed with double space. Thanks for the fixes. When I copied the sentence from the email, there was indeed double spaces in it, but I simply ignored and "fixed" it, and I also didn't double check the used style in mm/percpu.c. Will be more carefully next time.