From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m76Dn8Hh526920 for ; Wed, 6 Aug 2008 13:49:08 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m76Dn7qU2580576 for ; Wed, 6 Aug 2008 15:49:07 +0200 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m76Dn7St005900 for ; Wed, 6 Aug 2008 15:49:07 +0200 Subject: Re: [PATCH] hugetlb: call arch_prepare_hugepage() for surplus pages From: gerald_IMAP Reply-To: gerald.schaefer@de.ibm.com In-Reply-To: <20080805133216.cc5c14cf.akpm@linux-foundation.org> References: <1217950147.5032.15.camel@localhost.localdomain> <20080805133216.cc5c14cf.akpm@linux-foundation.org> Content-Type: text/plain Date: Wed, 06 Aug 2008 15:48:50 +0200 Message-Id: <1218030530.7764.18.camel@ubuntu> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, nacc@us.ibm.com, agl@us.ibm.com, Nick Piggin List-ID: On Tue, 2008-08-05 at 13:32 -0700, Andrew Morton wrote: > > --- > > > > mm/hugetlb.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > Index: linux/mm/hugetlb.c > > =================================================================== > > --- linux.orig/mm/hugetlb.c > > +++ linux/mm/hugetlb.c > > @@ -565,7 +565,7 @@ static struct page *alloc_fresh_huge_pag > > huge_page_order(h)); > > if (page) { > > if (arch_prepare_hugepage(page)) { > > - __free_pages(page, HUGETLB_PAGE_ORDER); > > + __free_pages(page, huge_page_order(h)); > > As Nick pointed out, this is an unrelated bugfix. I changelogged it. > Really it should have been two patches. Ok, thanks. I didn't see it as a bugfix because it doesn't make any difference on s390, and nobody else is using arch_prepare_hugepage() so far. But of course this may change, so I should have made two patches. > afaict the second fix is needed in 2.6.26.x (but not 2.6.25.x), but > this patch is not applicable to 2.6.26.x. > > So if you want this fix to be backported into 2.6.26.x, please send a > suitable version of it to stable@kernel.org. Right, this was missing from the beginning. It affects s390 only, so I'll check if we need a backport. Thanks, Gerald -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org