Re: [RFC PATCH 1/4] kmemtrace: Core implementation.

[Pekka Enberg <penberg@cs.helsinki.fi>]

Hi Eduard-Gabriel,

On Mon, 2008-07-28 at 20:35 +0300, Eduard - Gabriel Munteanu wrote:
> > > > +struct kmemtrace_event {
> > > > +	u8		event_id;	/* Allocate or free? */
> > > > +	u8		type_id;	/* Kind of allocation/free. */
> > > > +	u16		event_size;	/* Size of event */
> > > > +	s32		node;		/* Target CPU. */
> > > > +	u64		call_site;	/* Caller address. */
> > > > +	u64		ptr;		/* Pointer to allocation. */
> > > > +	u64		bytes_req;	/* Number of bytes requested. */
> > > > +	u64		bytes_alloc;	/* Number of bytes allocated. */
> > > > +	u64		gfp_flags;	/* Requested flags. */
> > > > +	s64		timestamp;	/* When the operation occured in ns. */
> > > > +} __attribute__ ((__packed__));
> > 
> > See below for detail, but this event record is way too big and not
> > adapted to 32 bits architectures.
> 
> Pekka, what do you think?

i>>?Mathieu does have a good point of optimizing the memory use of an
individual event so I'm okay with that. But we really don't want to
force people the analyze the dump on same architecture where we captured
it. So as long as that is taken care of, I'm happy.

		Pekka

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>