From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95ADDC77B75 for ; Tue, 23 May 2023 02:48:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E1B2900002; Mon, 22 May 2023 22:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C126B0075; Mon, 22 May 2023 22:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13283900002; Mon, 22 May 2023 22:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 00E7A6B0074 for ; Mon, 22 May 2023 22:48:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CAB99AE061 for ; Tue, 23 May 2023 02:48:23 +0000 (UTC) X-FDA: 80819986086.02.3A3466B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 01F8240008 for ; Tue, 23 May 2023 02:48:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C08IctqN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684810102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YAyVk5JwzLmiOe+8xYiBMe8j96HURcmjIvBEr+arm2M=; b=siLskyXr+tK/WoywrHbGzuhJTIFoF1C8Iqqje4SWFuiHHP+MJA0M4ZW8GbKgxwWsuija32 jtn5NdNuHai1ORHN+GedqkHF7SA4lCCOEnEwHeno9mDmn5+mHBdaeTYSahfDnYlrP9vZdP mIgcMvZMSm4kJmlNz8hwwVOteuY+kZg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=C08IctqN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684810102; a=rsa-sha256; cv=none; b=zl70kBRrSxxZF65Eube9FrlcdkslgFbGoSppUh2oDUCUtpB+TA/MZ4iDEMKzAE5UxqeMkH 7PRiIAlAEI9pPFiXKIEyIyMcZfGnSjIack9RQpWV5O9pv9P+JIccVeqZA+gZqbF6BAmPP4 LXkWngvT8F3H31H4H/YH0YKs1NIW3wk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED34662E31; Tue, 23 May 2023 02:48:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06332C4339B; Tue, 23 May 2023 02:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684810100; bh=w3PG+wvDxKl0ccqPHuJb+taZwlEJrTezcF9g2TqXZ1g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=C08IctqNP5/PmceTbld2x6Z+tyTSwkltOrcprZv2cE3Uo496FntDjRuVS7M+Gpm2K U3cEe5vUgZ/7eUJhqG72NHK9lzGdtlP0BhZEzo4aOLxqWQOy2sSMMZWxhCG6Gfxmc7 RNc/9BRwtQMCgX2cvdE35U5dVrPXYWf22vm8KWmEnZP0Luge4ya7MjlSfuu9rbNnBa 8Ifj2kGXSoBEIod8Jpy7qPbz0/Bik3NHxxM106v7S+Yv14USfaHgu95Xz3kAOgUDNW 5e1OnDfiRNQrkotrhbtQj/7CWQ6wR24GZzTJgeS7gVP4kaz5vmXOJGP0a5bMhH9ALV Neh/UjY9p1DXg== Message-ID: <12153db1-20af-040b-ded0-31286b5bafca@kernel.org> Date: Tue, 23 May 2023 11:48:17 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v22 25/31] zonefs: Provide a splice-read wrapper Content-Language: en-US To: David Howells , Jens Axboe , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org References: <20230522135018.2742245-1-dhowells@redhat.com> <20230522135018.2742245-26-dhowells@redhat.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230522135018.2742245-26-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 01F8240008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: umdd8zhp5tqp81bj6tbh5cx4p3no1ayz X-HE-Tag: 1684810101-321575 X-HE-Meta: U2FsdGVkX18A9v0hT6CaFbqHZCj4XKhiH5r2eF0q0HfcgT9AjBH6VhgPp+PpwyMFSJxDCnCP8GjgXv2fl1nP/jEV8ZQ6N9uhi6vF3lW1JXwLnBRzPDkSW22DvTGg15OmVyg8l9+QhI7EbhNlA4sC5OnQ2e+9wSNATbDeEprN3fTXt1Ooo4gPlMDU1kCIBh2aBbVw310uta+xj9qd/ou5giNwOgP6qTjPNzTDAH4TKzdp6iJB5aRGwJR17IHXDRVWC4li8XEhGz0LTK/0SWNzzBFHQ22vXOdoS3AGmF35Bb86GV7a52NPDIv8TYouPbF+4/8/p/WCtWJ6VpznxXQl4Rd5bOtNcTyQ5S2LivAQuBInC75kQlLG6u50FDbr9ZAr1rFNIuqsiO5lRfpd0yXEgllNUmh4mykVbFMV+f76W8YcSGaTkDQuRVwg18NQe80VDiWFxk4/FH6OgesZotskuKW0sbdYY5VpIstSglvDLmdvNMjRJFCji8/Vl0MBd6ulkFCBemDzfXBCwwhj96wIWE6APPXHqvr8E+EZyjZLIcJSsTRoKA39+SaoBeLgcPlSUbNTMYKUtKwnXXVrHwT/iKXes8GToslGdxNU0xgwKAmOoCDci8hhmzda8fIwE45qDg3iHNGLwptS4ptNcN3fjqDpWdFIVVHeBHLKD85wM5vPkIURuJX6rOxQpPZMl/xnSP+i6hTnqpfC85veCkH20B3IyIcvmf5YL+r0wec4l000qR+pHD/naX/vsUkvzpUGifKTZ0OeWToH5L+Oi5ne+eONs+OsaBXUnURnrDku+0Lx9lc4vNMeZwgD9RKJ3amut7yNgdfq1iFWBj+T6+bnaqGCpcv9imySKhuE8XTOhaBKh7wXFoFxWHe6L4ozTraEqVhq7cHT0xKEwwtcpI/k+oLtkolyVca6tJZSe1NWYiaZwHqcNtHNO/5h4MzoPXna88EdEyPm6+Rq4TpvK+g wVGkrmaF MHl3nFlpOnQUfQkIYgr3OKcVwOC2Xg1GpvXunbRwMgmKqAADkOrWMQ84Ik0OQUYD9KuEy54Pwrx8iFoLvvO+hxGW8gQrGtJNAWFvOAEJP4hPzbCtc22fwWYv3f5nJcBet1/6CXOhS5cGgugd2MvVqCPmBhoq9F4wCTkZG0UU7RtkrZGXbMTaf1zEZuAnvK6wtBpcBqh5HknI3zFeg1P6tRiw7Tz2/3TR6qswAFBwBUr0YU+nNqVpho2QPXQyciemQD+sPd5/6YbyOPV0JXKhKh+QX/ITltSESekA1OYWH63s+YWdOaWUFSNmbt7RHfseVk7Ql8X9jdl4at4wJvQ0C1jdK7miwI661Y2iX0OpUUmfcn38d/n/eFiBCD/Qmyia+ps6LSCReqmAuWI//8nHlztHm4Qw7sdyx2I9CCezvKVRdgvDdnM2Fljx/NZMLXf7x2uKCc9yqlt0QJa3D1oQvLkG9vgI4+fc6flIp+sL/UIIRiKBCTg2qTOBPAjon9V43ssS0DJKxmULvwJ/cm2+hFkC0MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/22/23 22:50, David Howells wrote: > Provide a splice_read wrapper for zonefs. This does some checks before > proceeding and locks the inode across the call to filemap_splice_read() and > a size check in case of truncation. Splicing from direct I/O is handled by > the caller. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: Darrick J. Wong > cc: linux-xfs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org One comment below but otherwise looks OK. Acked-by: Damien Le Moal > --- > fs/zonefs/file.c | 40 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/fs/zonefs/file.c b/fs/zonefs/file.c > index 132f01d3461f..65d4c4fe6364 100644 > --- a/fs/zonefs/file.c > +++ b/fs/zonefs/file.c > @@ -752,6 +752,44 @@ static ssize_t zonefs_file_read_iter(struct kiocb *iocb, struct iov_iter *to) > return ret; > } > > +static ssize_t zonefs_file_splice_read(struct file *in, loff_t *ppos, > + struct pipe_inode_info *pipe, > + size_t len, unsigned int flags) > +{ > + struct inode *inode = file_inode(in); > + struct zonefs_inode_info *zi = ZONEFS_I(inode); > + struct zonefs_zone *z = zonefs_inode_zone(inode); > + loff_t isize; > + ssize_t ret = 0; > + > + /* Offline zones cannot be read */ > + if (unlikely(IS_IMMUTABLE(inode) && !(inode->i_mode & 0777))) > + return -EPERM; > + > + if (*ppos >= z->z_capacity) > + return 0; > + > + inode_lock_shared(inode); > + > + /* Limit read operations to written data */ > + mutex_lock(&zi->i_truncate_mutex); > + isize = i_size_read(inode); > + if (*ppos >= isize) > + len = 0; > + else > + len = min_t(loff_t, len, isize - *ppos); > + mutex_unlock(&zi->i_truncate_mutex); > + > + if (len > 0) { > + ret = filemap_splice_read(in, ppos, pipe, len, flags); > + if (ret == -EIO) Is -EIO the only error that filemap_splice_read() may return ? There are other IO error codes that we could get from the block layer, e.g. -ETIMEDOUT etc. So "if (ret < 0)" may be better here ? > + zonefs_io_error(inode, false); > + } > + > + inode_unlock_shared(inode); > + return ret; > +} > + > /* > * Write open accounting is done only for sequential files. > */ > @@ -896,7 +934,7 @@ const struct file_operations zonefs_file_operations = { > .llseek = zonefs_file_llseek, > .read_iter = zonefs_file_read_iter, > .write_iter = zonefs_file_write_iter, > - .splice_read = generic_file_splice_read, > + .splice_read = zonefs_file_splice_read, > .splice_write = iter_file_splice_write, > .iopoll = iocb_bio_iopoll, > }; > -- Damien Le Moal Western Digital Research