From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3 From: Lee Schermerhorn In-Reply-To: <2f11576a0806241035p45a440e1gb798091ef39cffc8@mail.gmail.com> References: <20080621185408.E832.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080624184122.D838.KOSAKI.MOTOHIRO@jp.fujitsu.com> <1214327987.6563.22.camel@lts-notebook> <2f11576a0806241035p45a440e1gb798091ef39cffc8@mail.gmail.com> Content-Type: text/plain Date: Tue, 24 Jun 2008 13:48:28 -0400 Message-Id: <1214329708.6563.43.camel@lts-notebook> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: Andrew Morton , KAMEZAWA Hiroyuki , linux-mm , LKML , Rik van Riel List-ID: On Wed, 2008-06-25 at 02:35 +0900, KOSAKI Motohiro wrote: > > 'lru' was not being set to 'UNEVICTABLE when page was, in fact, > > unevictable [really "nonreclaimable" :-)], so retry would never > > happen, and culled pages never counted. > > > > Also, redundant mem_cgroup_move_lists()--one with incorrect 'lru', > > in the case of unevictable pages--messes up memcontroller tracking [I think]. > > indeed. > sorry, I forgot to send this fix. > > Acked-by: KOSAKI Motohiro > > but I still happend panic on usex and nishimura-san's cpuset migration test. > -> http://marc.info/?l=linux-mm&m=121375647720110&w=2 > I saw the description of the cpuset migration test. Have you wrapped this in a script suitable for running under usex? If so, I would like to get a copy. Actually, please send me any automation you have for this test and I'll incorporate it into the usex load. Meanwhile, I'll take a cut at adding such a test to the load. However, we know that your version can provoke the panic, so I'd like to get that. > > I'll investigate it tommorow. Later, then, Lee -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org