From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1EEC54ED1 for ; Sat, 24 May 2025 02:39:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5C296B007B; Fri, 23 May 2025 22:39:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0CDB6B0082; Fri, 23 May 2025 22:39:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFC6B6B0085; Fri, 23 May 2025 22:39:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B060D6B007B for ; Fri, 23 May 2025 22:39:08 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 844288144C for ; Sat, 24 May 2025 02:39:07 +0000 (UTC) X-FDA: 83476244334.26.2524EE3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 36A991C0007 for ; Sat, 24 May 2025 02:39:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J2qaMpL2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of ddutile@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748054345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rQHeLaYHvKxF+GHtQN6xMn9GC9P8oUvc+3z8s3Wst4A=; b=7yLedLldV/39KbBuwQFc1MPeU6jPXl4wXc4A72+HBq8fQvMaHnIfuwFUHUIRj8HRDOVSfz 78aWtEu0Uzhx5Ly/rLmL/MTdGL+Sp0ybr3hFwWWlU7pPbz25+01Au8UExciYW66GxW3XPS 6Re+ASm5XL9A3kp/3csTkFKDp7JCfH4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J2qaMpL2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of ddutile@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ddutile@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748054345; a=rsa-sha256; cv=none; b=HrPvosmSQieetFyNCFwbnqzYo4vyRrdznK1GgljtiZtVbk7yrVxJw9CaDkr/VMi0vsVkpa TzguIGz8u/AbNAMJa0FIdJjj0wSTKpZ6Ytd1QQ0L7SWJKaQDanfohAGkUDXbtiKRsoJdvu 0Kf1AURS05Cmk/vgBghhr3pIFYTPKtg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748054343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rQHeLaYHvKxF+GHtQN6xMn9GC9P8oUvc+3z8s3Wst4A=; b=J2qaMpL2ApVfcFqG22nLxbVsTN8r1S1pR4ms8n4l3CrTAVA9cCWF6Dn81OgIk66OUABdN3 uedCfQoXt0zBAQoa5XbhdUnqXJrZwXfHEhzYtiitVedrpEnPtkocs2XdgaUynU+bpRMiet PsOmwPJOT2Jol4E5yWJo5z7kPeJSk/c= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-iGUc7XkwOW-YnHZjOsui3Q-1; Fri, 23 May 2025 22:38:59 -0400 X-MC-Unique: iGUc7XkwOW-YnHZjOsui3Q-1 X-Mimecast-MFC-AGG-ID: iGUc7XkwOW-YnHZjOsui3Q_1748054339 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c760637fe5so74810085a.0 for ; Fri, 23 May 2025 19:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748054339; x=1748659139; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rQHeLaYHvKxF+GHtQN6xMn9GC9P8oUvc+3z8s3Wst4A=; b=LDYc/YGb8ds9Azi2oKR2ufG6i8ft0TemoBF+igziJJHIgoJlKfO6NO/heKHc60Rpg5 uu/AiY33mXgPfmM3tKePldtqLHQ33K/XwlEqaR6xS+75vAkbYsWevApXnvg+G1Fl6gyA G7q5XGsRvypMxRtuEPQHX7gm0WF1aDwxzxeqLB4wFoESvMizW8TIkSxH9nWfta8yO52x /K6gdyAB+4XUFvpHClG4YuUkWLVWh3MbjnFZ512mMgiYdigcMKfsuTVJ6lBY0Na5Cume KmehCokKcIkTM5bI1CiB8fZG8BLp1ULR5fpEC7w8EyUkAoViXDNNyfAtFA7l29zFXlhV 3fEw== X-Forwarded-Encrypted: i=1; AJvYcCVUKMgfEHeQqXukp6Xw2BaVE+B+7uNVqM28QmentSULwZCt037YEBIBiDri2g//4YurcP9znPG4sA==@kvack.org X-Gm-Message-State: AOJu0YyB1FYyYxMKcTsk6jYEC2POD5Kbis9Fxbon/uqTvjeHOgb/a6FR jqEmRBVjmbAzFIc63Hep182x1aeQLJ+K8+lwmSeXAz9pieuUR/IPrv+7jxco8W2qZKDr/zUgzSt Rw6ZsGJkEAIJGBZlyAdddpeQvzbNGDIToWyk9653e8QcQiPvW1Bmu X-Gm-Gg: ASbGncsEZssHcYFvdwq7BidR0C79eWfj131kDjz1+g8M1ms7c986uFRo6HCBx09Yr7U jFH9jmB2ISWS4E1DIYyc3rk5rtV2zlt5x3vMSZSAiIqGnoMCy1fX6cAO9JZ5kcADRynOa4IlODr S/ze/NLvJVTq/I+YgWs7oiXhvf6w9BkxAlOlkECFIbUjazVddRmOdAGddadxw6lMSgvPG+dHezZ uOXJi1YFJmVJi1rhffJRxNBl+OJtrVtPynu7pLieljs2IPakdbHxmykQXk1J36w5m/9B6Q5Vztp PCxtUP8GpQE7 X-Received: by 2002:a05:620a:1d0d:b0:7ca:c9cb:ab1 with SMTP id af79cd13be357-7ceecbbd282mr229954785a.7.1748054339361; Fri, 23 May 2025 19:38:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErmUUHEKNy3Y7AV9txFdGa7R9r1caA7oXdVsktniXZg9N1+JC4HDh8WDXEKjBXaAJ0HK1AXg== X-Received: by 2002:a05:620a:1d0d:b0:7ca:c9cb:ab1 with SMTP id af79cd13be357-7ceecbbd282mr229952285a.7.1748054339037; Fri, 23 May 2025 19:38:59 -0700 (PDT) Received: from [192.168.40.164] ([70.105.235.240]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7cd467ef2fbsm1271523485a.59.2025.05.23.19.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 19:38:58 -0700 (PDT) Message-ID: <12136dc2-41c2-45f4-b1f0-cd9d2e853e76@redhat.com> Date: Fri, 23 May 2025 22:38:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/5] KVM: arm64: New function to determine hardware cache management support To: Ankit Agrawal , Jason Gunthorpe , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "david@redhat.com" Cc: Aniket Agashe , Neo Jia , Kirti Wankhede , Krishnakant Jaju , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "tabba@google.com" , "qperret@google.com" , "seanjc@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "maobibo@loongson.cn" References: <20250523154445.3779-1-ankita@nvidia.com> <20250523154445.3779-3-ankita@nvidia.com> <9ffc7686-0dc0-4978-8cd8-f12a1c148b63@redhat.com> <9b429da4-8db6-407e-9721-178e01fd1ebb@redhat.com> From: Donald Dutile In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 60uW5hY0j1KPv1PzAbY4SfftGfaX0QVuGKvL43dc78c_1748054339 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 36A991C0007 X-Stat-Signature: jp6hc9angpbg9egsp1ca1ukenynptnei X-Rspam-User: X-HE-Tag: 1748054344-277189 X-HE-Meta: U2FsdGVkX19LY04jygEbXYra+wq4MQI5Z+q1pnClXHyvzKymu5O9KK02Hlwq4/0hXVPQ1AkELxiRzOXQiQXhDnPjAaCGM5Qsy4rppOSW5sKxbjHv1KFGnkI6rbbpe0g1bUBiVUJ0gz1ZX9Xo/FU1j3t+9y2/aXk36lg+1Jm9pfzKXisQr8fAdxXopT2nNsX/nLCEaMPBiLOYaaVUXnmBEw1iX2C6cDqyPpSEht28Br2a+I8sxGqrIeLcxwAMGpjOjZdPHyrwbjRPWwgDVHK83YqSUHAChgim3esXPQ/ZPq4bt/nC8LFH67YOiBNXfZDJqpmVuw2GvrMLO8gahy1ocw079wNK/4j5VWju9LpTtwSLOwV8dOUUOyi1ySbb3PBacrJvs3cpsZhTh91LF4iv35qyvwP1d++L1Q9V5qRKRy8IZx7Gt3it2rIq4ci/JtH0WuzzQmczMGPjZgEJB+JM8TygAqub0uDIQysfQuQfPjztXU6ZV2YswLlISJO5/+HU3C1kIB73ATHPTJlApnsZ85AU7G33E8DEAahHBPWZ95lT+3POBq3+jmCvKqPBnEMhXuEFSDJwYX+hnZggMLmDqHWYXSaJXhOIgACcVs+lc34ohzBN5CRwviFz7uLveZE3oa9QRVGYaOH1K/9uwroFToPb2kmSZuxMpdOdYSXRh60Gus1+GAlDRL41iDPQsTfI5guI3xMR/QKbLK0rtZpAbE9EtvYQmxYkZSSYex5FrTOtkb2GzhrIFwjR7SOTm2YU3Y4Nuaj1zj7uvPsxBhG1gzMhwalZPS6FN2x0TVVXDbxNdiaLSDLp44BN5Myn9KINeTnjLMwsGNMOlJRpBoKLWu/QBmYOVoT9sdgmpzdE7fAry4BQwko8sNTKWouxe106vBjfSd6v7EBifvHhZct+kCGBlIajJMo8uBvfQdhQYwdMfSsoVqM1DuGov08xCXZ/POuVvSbuWdaMj2mae9j pUmodkyA msiLy/gLLO4PrsUpqFEyaEtAF9p7ubsLWXoY/7uvSVxulSKueb1ZcUAZA+JcGggLB5PfQshouN6czekhApekL5/M1sy2me/MnoLTMkgfNkvwfleCaoEYhmLfbINvynLNBsfVLUtUMRLhoiJJfZrNNm2eVSDdI9glS134eqJ1uIjANzo9V4mbN1dG3AbxR7QpSgDnHN7NmhzeLVx6VKtGx/4BBx//b2ja9EzWZ1HiCqiWWXQUKIEjcXsPyjUEzvVkAc63Ig9NKFRn6QjrXORq04Uy+SwL+pKSDKHrQLILgJNAMijUWfxwhSRCpNSOkKd4tPZ3Kmv3tMNMDjlGugPla5gzarqNv2t+XWxQ88ePuEuQaTqbbrozjNqErTg+Hz+tDOoJZWIIQEDhiSHHxH++0wwTe5cplIQFiD5Vg1Wc10GPn7eg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/23/25 9:41 PM, Ankit Agrawal wrote: >>>> +/* hardware support cache management */ >>>> +bool kvm_arch_supports_cacheable_pfnmap(void); >>> Won't this cause a build warning on non-ARM builds, b/c there is no >>> resolution of this function for the other arch's? >>> Need #ifdef or default-rtn-0 function for arch's that don't have this function? >>> >> >> ah, I see you have the weak function in patch 5/5. >> But I think you have to move that hunk to this patch, so a bisect won't cause >> a build warning (or failure, depending on how a distro sets -W in its builds). > > Thanks Donald for catching that. Fixed in v6. > Thanks for fixing the nit.