linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matt Mackall <mpm@selenic.com>,
	hans.rosenfeld@amd.com, linux-mm@kvack.org, hugh@veritas.com,
	Rik van Riel <riel@redhat.com>
Subject: Re: [v4][PATCH 2/2] fix large pages in pagemap
Date: Wed, 11 Jun 2008 13:34:22 -0700	[thread overview]
Message-ID: <1213216462.20475.36.camel@nimitz> (raw)
In-Reply-To: <20080611131108.61389481.akpm@linux-foundation.org>

On Wed, 2008-06-11 at 13:11 -0700, Andrew Morton wrote:
> Really?  There already a couple of pmd_huge() tests in mm/memory.c and
> Rik's access_process_vm-device-memory-infrastructure.patch adds
> another one.

We're not supposed to ever hit the one in follow_page() because there
are:

                if (is_vm_hugetlb_page(vma)) {
                        i = follow_hugetlb_page(mm, vma, pages, vmas,
                                                &start, &len, i, write);
                        continue;
                }

checks before them like in get_user_pages();

The other mm/memory.c call is under alloc_vm_area(), and that's
supposedly only used on kernel addresses.  I don't think we even have
Linux pagetables for kernel addresses on ppc.

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-06-11 20:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11 18:02 [v4][PATCH 1/2] pass mm into pagewalkers Dave Hansen
2008-06-11 18:02 ` [v4][PATCH 2/2] fix large pages in pagemap Dave Hansen
2008-06-11 19:37   ` Andrew Morton
2008-06-11 19:53     ` Matt Mackall
2008-06-11 20:11       ` Andrew Morton
2008-06-11 20:21         ` Matt Mackall
2008-06-11 20:34         ` Dave Hansen [this message]
2008-06-11 20:52           ` Andrew Morton
2008-06-11 21:01             ` Rik van Riel
2008-06-11 21:23             ` Dave Hansen
2008-06-11 22:37               ` Matt Mackall
2008-06-12 21:36                 ` Hugh Dickins
2008-06-12 22:35                   ` Matt Mackall
2008-06-11 20:15       ` Dave Hansen
2008-06-11 19:35 ` [v4][PATCH 1/2] pass mm into pagewalkers Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213216462.20475.36.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hans.rosenfeld@amd.com \
    --cc=hugh@veritas.com \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox