From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EA8BCAC5A8 for ; Thu, 18 Sep 2025 08:34:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 638348E00CF; Thu, 18 Sep 2025 04:34:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FDA8E0093; Thu, 18 Sep 2025 04:34:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525B08E00CF; Thu, 18 Sep 2025 04:34:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 409778E0093 for ; Thu, 18 Sep 2025 04:34:16 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C6D8787641 for ; Thu, 18 Sep 2025 08:34:15 +0000 (UTC) X-FDA: 83901708870.15.3D23ACE Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf02.hostedemail.com (Postfix) with ESMTP id D8ABE80008 for ; Thu, 18 Sep 2025 08:34:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NAzFNn9G; spf=pass (imf02.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1758184453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iHPyCqwaIE53kfvtOqEjL6h4xRme2WCE41tGRMbg4OA=; b=4Uo+eaYJxoiDnu0yY2O2K3i/g8GqZgPcnsxVnqFTzI91RdA693JwLg5Ks6hwr6upwet+Vv 90Cd/N5K/SNMEtjS0u7oxwEypJaQ7PIfcuNYNObgJ12MjVX9xHz1zdF33jsXsE45wA31fJ zRu/ocR2vEU949LTnh3dGDc0cYxwlpc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1758184453; a=rsa-sha256; cv=none; b=bX4hl5C1wMaUCYFpCcyqCqwGPCjWh0jBWTncHTXtnnkOeAtiCiRPKjoE8n4ohxHr6whiPR sRLBdIVDHoOheJcFD5A/Ay4hY0LKUyATW9y/Pf25P0IkdfWuOss8QLnpbH0KJPrGtsVai8 lRo+3sEmr639H/jwMxcybwFlj+P0uW8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=NAzFNn9G; spf=pass (imf02.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1758184447; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=iHPyCqwaIE53kfvtOqEjL6h4xRme2WCE41tGRMbg4OA=; b=NAzFNn9GOVJAkfAMVdrcB07/dc9Ms6BXy74/eleljuE18J5xeCe+MSNCWI7mIBMNSKnAqNLzjwLm6kSAz8lYe1mcIwN/wPqqqWp2scY/NlMqRt6OvyP2fdTyiQYDDC+xHtbgB7ivv075GdoONkKJHKPWItxHsyJUsKpC8Jrumlc= Received: from 30.246.178.33(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WoFHDqY_1758184444 cluster:ay36) by smtp.aliyun-inc.com; Thu, 18 Sep 2025 16:34:05 +0800 Message-ID: <1211fd9a-93e6-4ebe-a80d-083601138b70@linux.alibaba.com> Date: Thu, 18 Sep 2025 16:34:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory-failure: Support disabling soft offline for HugeTLB pages To: Kyle Meyer , "Fan, Shawn" Cc: "Luck, Tony" , Andrew Morton , "corbet@lwn.net" , "david@redhat.com" , "linmiaohe@huawei.com" , "shuah@kernel.org" , "jane.chu@oracle.com" , "jiaqiyan@google.com" , "Liam.Howlett@oracle.com" , "bp@alien8.de" , "hannes@cmpxchg.org" , "jack@suse.cz" , "joel.granados@kernel.org" , "laoar.shao@gmail.com" , "lorenzo.stoakes@oracle.com" , "mclapinski@google.com" , "mhocko@suse.com" , "nao.horiguchi@gmail.com" , "osalvador@suse.de" , "Wysocki, Rafael J" , "rppt@kernel.org" , "Anderson, Russ" , "surenb@google.com" , "vbabka@suse.cz" , "linux-acpi@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-mm@kvack.org" References: <20250915201618.7d9d294a6b22e0f71540884b@linux-foundation.org> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D8ABE80008 X-Stat-Signature: stu4wuzew6r6yjmxd8cwfwro577caqbc X-Rspam-User: X-HE-Tag: 1758184452-386045 X-HE-Meta: U2FsdGVkX19kgI1iqn7tSGPgrE+yIpsYhkUD3V0UqKO0AjFkhvdikGhcUi1QlXMNNh8ooqJRKZ3Ttp9Gb5xzAwcrbFNMFZwYXpFmIUaubAfmmcgT136aQPbEnSpm+EHN/kC2VnkaqHcLo9H+ie4/OC3M4pTb9HMoVZJripzIjdYKFMvC79ZTn1wCGbx1A3w/62hqB4wyEF8z/MOTZ6veXwmQc/NLpTmtOwDk4Ur18sjDwwOxrt1osIWctb0+bs5zxFrXvsuh3h0C8j1FyoAVNxv0025UlB6Ex3BmHBHRXzh98a9HRDQawEn0bI6TOWtckeG4aBIdWg8zX01rCEyb/HZSkdOFqbsYnas2S6xOym6Rt9ip4qexlXXZAlvcub/fX2XmBwlSJHPT88KoYaAjd7JOIRUBHd1IDRg+Vl8uW5zE/K6FG0INw2WZuiAvzooqActbeRHC6N+gvT6FViJEi1jGjgxfbpqaVs5PPhXvmZjuKiv2yXAImvli+W8QcYkntqM/NGktcT85Mam2SYO327AGFe8PCYUFBPWMP0uFYap2vZYPFAjkvyxOoKBiGAz8YELmZfEWOwr6s7IEB5VHSbOJV37DCaREOX4dC/5LC86UJiBazi3ns++kb5eQw4s+BFJ0ebGPmaNr3yamFgaGFbPuR0hCyPiINU+n3ubyobQKxK3tbH00HDSSLURMMpBz8JJEtXyMZsXQJUIFMD8YkJ6GiUwlewpbPyvWqdtCZuw7i3ZL+7d06/gyc5oOy/2fhdMMzzvdSJGn6rPel3fOsf87UVql7Zss4skBx9hPQ1lcSqgEGR/XouzXJcWl51dCMJ65M7zaF+3aakyWJzhXRAC0EHRemb9N16hhKslYhnYApAhQa12l8QrB0oFpwbzX896voAnLmrVU848JUGL+wWT8Ru6lH3d3GJcEq5y7JXT3tWqGUxKjH945uGDEgPIx7Niw2rvWlrVkuoMLI9y B1fA8nVl 5AodeYH9MLMUbgjl37S+Z7cBgph8+8+VT7wm41vQaCeOKBLdV8oBpmx+juAjHZuQNNckuqwBmSAvwhkciuv4UpB3OF4WpEHScplTP+mKWH/SsF32cuk40YHxWGJH+51wrS0+i6nSDEI7QJ7HXKy8wLXXDegriG/jlY/7bfQKlYpEBQrKz+r2v4Szft8HFQwzUIH7YUXzZBs+vYT5BwlYUM/k9NAFTQPfC9QepoDvCsPqpR2th2JGswZ0/Gjg6sWc9dy+yzme4ayasRwVHIEo5gPIZMF8mGunnh1sSFVxGdx8r5ziHTiQQh+Hc9DgzIbPeavkqZxvSlqW6oD/78JSUI/WB02ld8jF/d3H6R5ssxYyWgoTRleFrxWpIR0LfNPWNudJ+FQXe8lSkw1cxkZFCD2pCzW8+HmXmcSgm2m8PflZ1KKHkAO12vxSehzbxy+sR7ZyW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/9/18 02:59, Kyle Meyer 写道: > On Wed, Sep 17, 2025 at 06:35:14AM +0000, Fan, Shawn wrote: >>>> My original patch for this just skipped the GHES->offline process >>>> for huge pages. But I wasn't aware of the sysctl control. That provides >>>> a better solution. >>> >>> Tony, does that mean you're OK with using the existing sysctl interface? If >>> so, I'll just send a separate patch to update the sysfs-memory-page-offline >>> documentation and drop the rest. >> >> Kyle, >> >> It depends on which camp the external customer that reported this >> falls into: >> >> 1) "I'm OK disabling all soft offline requests". >> >> or the: >> >> 2) "I'd like 4K pages to still go offline if the BIOS asks, just not any huge pages". >> >> Shawn: Can you please find out? >> >> >> -> Prefer the 2nd option, "4K pages still go offline if the BIOS asks, just not any huge pages." > > OK, thank you. > > Does that mean they want to avoid offlining transparent huge pages as well? > > Thanks, > Kyle Meyer Hi, Shawn, As memory access is typically interleaved between channels. When the per-rank threshold is exceeded, soft-offlining the last accessed address seems unreasonable - regardless of whether it's a 4KB page or a huge page. The error accumulation happens at the rank level, but the action is taken on a specific page that happened to trigger the threshold, which doesn't address the underlying issue. I prefer the first option that disabling all soft offline requests from GHES driver. Thanks. Shuai