linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shuai Xue <xueshuai@linux.alibaba.com>
To: Kyle Meyer <kyle.meyer@hpe.com>, "Fan, Shawn" <shawn.fan@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"david@redhat.com" <david@redhat.com>,
	"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
	"shuah@kernel.org" <shuah@kernel.org>,
	"jane.chu@oracle.com" <jane.chu@oracle.com>,
	"jiaqiyan@google.com" <jiaqiyan@google.com>,
	"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"jack@suse.cz" <jack@suse.cz>,
	"joel.granados@kernel.org" <joel.granados@kernel.org>,
	"laoar.shao@gmail.com" <laoar.shao@gmail.com>,
	"lorenzo.stoakes@oracle.com" <lorenzo.stoakes@oracle.com>,
	"mclapinski@google.com" <mclapinski@google.com>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>,
	"osalvador@suse.de" <osalvador@suse.de>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"rppt@kernel.org" <rppt@kernel.org>,
	"Anderson, Russ" <russ.anderson@hpe.com>,
	"surenb@google.com" <surenb@google.com>,
	"vbabka@suse.cz" <vbabka@suse.cz>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm/memory-failure: Support disabling soft offline for HugeTLB pages
Date: Thu, 18 Sep 2025 16:34:03 +0800	[thread overview]
Message-ID: <1211fd9a-93e6-4ebe-a80d-083601138b70@linux.alibaba.com> (raw)
In-Reply-To: <aMsE9XjWKEYTIQyV@hpe.com>



在 2025/9/18 02:59, Kyle Meyer 写道:
> On Wed, Sep 17, 2025 at 06:35:14AM +0000, Fan, Shawn wrote:
>>>> My original patch for this just skipped the GHES->offline process
>>>> for huge pages. But I wasn't aware of the sysctl control. That provides
>>>> a better solution.
>>>
>>> Tony, does that mean you're OK with using the existing sysctl interface? If
>>> so, I'll just send a separate patch to update the sysfs-memory-page-offline
>>> documentation and drop the rest.
>>
>> Kyle,
>>
>> It depends on which camp the external customer that reported this
>> falls into:
>>
>> 1) "I'm OK disabling all soft offline requests".
>>
>> or the:
>>
>> 2) "I'd like 4K pages to still go offline if the BIOS asks, just not any huge pages".
>>
>> Shawn: Can you please find out?
>>
>>
>> -> Prefer the 2nd option,  "4K pages still go offline if the BIOS asks, just not any huge pages."
> 
> OK, thank you.
> 
> Does that mean they want to avoid offlining transparent huge pages as well?
> 
> Thanks,
> Kyle Meyer


Hi, Shawn,

As memory access is typically interleaved between channels. When the
per-rank threshold is exceeded, soft-offlining the last accessed address
seems unreasonable - regardless of whether it's a 4KB page or a huge
page. The error accumulation happens at the rank level, but the action
is taken on a specific page that happened to trigger the threshold,
which doesn't address the underlying issue.

I prefer the first option that disabling all soft offline requests from
GHES driver.

Thanks.
Shuai


  reply	other threads:[~2025-09-18  8:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16  0:27 Kyle Meyer
2025-09-16  3:16 ` Andrew Morton
2025-09-16  7:14   ` Kyle Meyer
2025-09-16 15:20     ` Luck, Tony
2025-09-16 17:59       ` Kyle Meyer
2025-09-16 18:08         ` Luck, Tony
2025-09-17  6:35           ` Fan, Shawn
2025-09-17 18:59             ` Kyle Meyer
2025-09-18  8:34               ` Shuai Xue [this message]
2025-09-18 15:48                 ` Jiaqi Yan
2025-09-16 10:12 ` Anshuman Khandual
2025-09-17  7:02   ` David Hildenbrand
2025-09-17 18:51     ` Kyle Meyer
2025-09-17 19:05       ` David Hildenbrand
2025-09-17 19:32         ` Jiaqi Yan
2025-09-17 19:54           ` Luck, Tony
2025-09-17 21:39             ` Kyle Meyer
2025-09-17 22:15               ` Jiaqi Yan
2025-09-21 11:36             ` Anshuman Khandual
2025-09-23  6:03               ` Kyle Meyer
2025-09-21 11:25         ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211fd9a-93e6-4ebe-a80d-083601138b70@linux.alibaba.com \
    --to=xueshuai@linux.alibaba.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jane.chu@oracle.com \
    --cc=jiaqiyan@google.com \
    --cc=joel.granados@kernel.org \
    --cc=kyle.meyer@hpe.com \
    --cc=laoar.shao@gmail.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mclapinski@google.com \
    --cc=mhocko@suse.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=osalvador@suse.de \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rppt@kernel.org \
    --cc=russ.anderson@hpe.com \
    --cc=shawn.fan@intel.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=tony.luck@intel.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox