Re: [RFC][PATCH 2/2] Add huge page backed stack support

[Dave Hansen <dave@linux.vnet.ibm.com>]

On Thu, 2008-05-01 at 18:51 -0700, Eric B Munson wrote:
> 
> +       if (!(get_personality & HUGE_PAGE_STACK)) {
>  #ifdef CONFIG_STACK_GROWSUP
> -       stack_base = vma->vm_end + EXTRA_STACK_VM_PAGES * PAGE_SIZE;
> +               stack_base = vma->vm_end + EXTRA_STACK_VM_PAGES * PAGE_SIZE;
>  #else
> -       stack_base = vma->vm_start - EXTRA_STACK_VM_PAGES * PAGE_SIZE;
> +               stack_base = vma->vm_start - EXTRA_STACK_VM_PAGES * PAGE_SIZE;
>  #endif
> -       ret = expand_stack(vma, stack_base);
> -       if (ret)
> -               ret = -EFAULT;
> +
> +               ret = expand_stack(vma, stack_base);
> +               if (ret)
> +                       ret = -EFAULT;
> +       }

Why don't huge page stacks need to be expanded like this?  With a large
EXTRA_STACK_VM_PAGES, you would surely need this, right?

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>