From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C6EC4345F for ; Fri, 12 Apr 2024 20:20:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 385536B0089; Fri, 12 Apr 2024 16:20:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 335236B008A; Fri, 12 Apr 2024 16:20:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 189316B0092; Fri, 12 Apr 2024 16:20:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EE9A86B0089 for ; Fri, 12 Apr 2024 16:20:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BA80D1A0FC6 for ; Fri, 12 Apr 2024 20:20:55 +0000 (UTC) X-FDA: 82001998470.06.D4B7A82 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 304AC20012 for ; Fri, 12 Apr 2024 20:20:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pqeWIKFB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G3Wj2ndT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="cHuo85r/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mUuuEEUP; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712953253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iDvcjL3Sj6DKOzUiHUApilKt2yFR24gfxfskdIfdUpQ=; b=QXZ+WU8pf9gcHvYcTS9WJA4fpwXiqmJWhvpXjTmiOoXmIfnDtHIbRCOxEO8evO5S0kglcG LR0A79uSNNvwdrM7RgY7Zo5aInitaSskqy1mNDD3wX5wTKje7RNUqD3/JidlFgFHLTGY1I Q6q7idsgsq4/yp9fK70LBENpfN17C2c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pqeWIKFB; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G3Wj2ndT; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="cHuo85r/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mUuuEEUP; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712953253; a=rsa-sha256; cv=none; b=kVmj6E0JKXjQCpsQ5NvhVPNCym6p+Nc9VhjopbBEMiR3lq4016qKHTVKF4qAHPZWFuPF3T GJsnfr1+skhuaI1zHDAldm/uMbbHLqgLjEVkm8/vRabibIx6s+ZVZE/l6NJqzLH3J11RUd HgSsau7frfmTQhavrm99EsY5Ps5t8x4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 10EAB1FB41; Fri, 12 Apr 2024 20:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712953250; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iDvcjL3Sj6DKOzUiHUApilKt2yFR24gfxfskdIfdUpQ=; b=pqeWIKFBalcTGIjsv9SHiKeP2hbNrh4QwWTHSmCpCGMg/MwQK0I7jXAUa3Ln/60UOAwYoh u6wgWniuw7rC5A1uDENlJa7DzS3OB6saa8yC6kJfXsv8kXEf9SmV4vnw2qlcu197Z4gcfl K7Z3PaG6wOKUJ0QK7W/Prbuy5drn4Mw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712953250; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iDvcjL3Sj6DKOzUiHUApilKt2yFR24gfxfskdIfdUpQ=; b=G3Wj2ndTaPc0XlbRZDVeEZErkJGkGf644xTB35jbiqE3fFwEYjHKgD69ZCgHOEkYfZiCwV JG7FYvcafuURisBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712953249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iDvcjL3Sj6DKOzUiHUApilKt2yFR24gfxfskdIfdUpQ=; b=cHuo85r/LG3lYg5CQx5E+cU7bxMXnspk3zTcvDcsw1u1zxsJ5x50y0Deao9SrPKFxqep1Q FeQuWyb40o03AOOWom/dlGKOTMgu4kFVtuyP6xGhwTwN2x6c2tSmWmFa2y583OnAR5HzUI FMpzppAGuukort0QiYW4tZZOgY0zF/Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712953249; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iDvcjL3Sj6DKOzUiHUApilKt2yFR24gfxfskdIfdUpQ=; b=mUuuEEUP8X2E6WEPMSdDC7G05hD3IGo+Zp8RraHrbutmWK2kXq1aTiu58rQst0rDqVaftO b9CJutxifouL2RAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E42171368B; Fri, 12 Apr 2024 20:20:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JylfN6CXGWapWAAAD6G6ig (envelope-from ); Fri, 12 Apr 2024 20:20:48 +0000 Message-ID: <1207c5d7-8bb7-4574-b811-0cd5f7eaf33d@suse.cz> Date: Fri, 12 Apr 2024 22:20:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [External] : Re: [PATCH] slub: limit number of slabs to scan in count_partial() Content-Language: en-US To: Jianfeng Wang , "Christoph Lameter (Ampere)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, junxiao.bi@oracle.com References: <20240411164023.99368-1-jianfeng.w.wang@oracle.com> <38ef26aa-169b-48ad-81ad-8378e7a38f25@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 304AC20012 X-Stat-Signature: 7jkqhakq7qbo1zxby4p7qhx48mndyg9h X-Rspam-User: X-HE-Tag: 1712953252-625625 X-HE-Meta: U2FsdGVkX19FKFY2rnxw9SB2NC+++3S6zxZaFDkKlHmdk6P3wqmwccE9R2j1NxDT/gkUZgOQC0XlJgEWchofnwTVFLLsmwTa1i8ptVDmKKksEn6LOMCTXtNHD0I7CgeORLVdpJMvP/TN2A3oWTiyeAZS/6E8faX2bQhY5MjeU/B+IKuZPHbn6xGoquTAl09IhvOWqmKzqzGWIs2yo8nX3F+HT9HQ/dE9DLe1Ge7CoXFSRTCH6aJ5/ZtMUpcI4EGs3H+UDQKkIH6q32LLVsI9+G46OtPCecyULsg37HtfpBoJ6MDtwBsYDV+gmEuUpxO/+S8q/M4f/Im6vQDyFfgrkvrEfgiwd9ZBa3+37pvABVQrLNyfpTwBDDGFPzniVrZKR9Iu3eT8AXH4SaCBDCfp8G5iVd3vFLHUvsnFJ+RmuZBNHKh1df3njdOHcwmDaljzp7vIRg3mAhpVjJeY5hAzAm3tSdpfXcMTvKqs28MOjPqBP+Xqx2qUDF9z4cdpPC3TjOA5/ZwMcN6O630xMW5gnBPzGQwrN74W8vUG06s0wrT+n4b7IT3KHbfawfIQ8W+QMD/ZZg6c+nA8Ln2gjUslWy3+jll0WjGCnsb0OIsrQ2G+hc2OF5j4R48P94r9rVomlPko5L1KsfJEbf3Zo+SDR8DQCaG6izBdc/PwunnTJXfee3sg1xOTA1Z/M6NU9/TpTfCrtx1Xd7u44nQ90IW9L6vKBXn2Qm/hPp0Z2BSVShSIHhsG9SsfqlzsDxjex9jjHSnwFnv5Yuji2lUMe+wlzfaqVKQjTRek8/ozqJ/I7s+EDwwuAbgORkGD7kPb4+drNxflZvUtUc1ahZHjMIFd/Bp/ZwyMWcd3C1CxwrGIaP73Ayt0AJzQeN8UpdiZcXOQW9dkZdhQcyF3Sqp0JRBuahgVGPUVqha6Fd0bcVpFIs2IxmeadiO52nyS+sDteIYlL9aETChqT9CxwjUiy4I c3j281c6 QE3Zn3E5jJm3U14BEReCuxSPAdDbQ+cSjRTOybC+nwP2JKwTCRSyV1NuKCRbGAwaaH7htLqdMnrAQeAZMn0vt7AiLFo9KGj+fM+v5hpSmxlvu+Y2Adw36NR4mwFWSj44swkDism9KKQwIG1Rp4ehiHzzAOqyRumXA7UqPadW8RIHoTP52yflHKz6NDkJ5X6N1u4esc2ETnnRn6qlGU3Ml/du7AaQpAudx4EqKGDv06qs8fOqdFGuM9uQbaZWpQ+27SU7PatrJhQaqjYq3Ub5Ft1EZkKtDW4isdbXZkehiIhFCeMDEtNCa3jL5mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/12/24 7:29 PM, Jianfeng Wang wrote: > > > On 4/12/24 12:48 AM, Vlastimil Babka wrote: >> On 4/11/24 7:02 PM, Christoph Lameter (Ampere) wrote: >>> On Thu, 11 Apr 2024, Jianfeng Wang wrote: >>> >>>> So, the fix is to limit the number of slabs to scan in >>>> count_partial(), and output an approximated result if the list is too >>>> long. Default to 10000 which should be enough for most sane cases. >>> >>> >>> That is a creative approach. The problem though is that objects on the >>> partial lists are kind of sorted. The partial slabs with only a few >>> objects available are at the start of the list so that allocations cause >>> them to be removed from the partial list fast. Full slabs do not need to >>> be tracked on any list. >>> >>> The partial slabs with few objects are put at the end of the partial list >>> in the hope that the few objects remaining will also be freed which would >>> allow the freeing of the slab folio. >>> >>> So the object density may be higher at the beginning of the list. >>> >>> kmem_cache_shrink() will explicitly sort the partial lists to put the >>> partial pages in that order. >>> >>> Can you run some tests showing the difference between the estimation and >>> the real count? > > Yes. > On a server with one NUMA node, I create a case that uses many dentry objects. Could you describe in more detail how do you make dentry cache to grow such a large partial slabs list? Thanks.